Verify mappings status in WireMock test container on startup and fail by default when there're no mappings#70
Open
oleg-nenashev wants to merge 1 commit intomainfrom
Open
Verify mappings status in WireMock test container on startup and fail by default when there're no mappings#70oleg-nenashev wants to merge 1 commit intomainfrom
oleg-nenashev wants to merge 1 commit intomainfrom
Conversation
… by default when there're no mappings
Contributor
|
I like the idea to have validation of empty mapping, but i would allow empty mapping by default and failed container only if developer explicitly asked about that (executed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #69 for #28 that uses the Wait Strategy to verify the response and say the container is not ready if there are no mappings. Unfortunately it is not going help with #28, bacause there is no way to abort the wait loop from the predicate.
Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java