fix: Parameter decorator bug parsing typescript#261
Open
ottodevs wants to merge 1 commit intowix:masterfrom
Open
fix: Parameter decorator bug parsing typescript#261ottodevs wants to merge 1 commit intowix:masterfrom
ottodevs wants to merge 1 commit intowix:masterfrom
Conversation
Using the old "decorators" plugin config was preventing import-cost to parse decorators in class constructors parameters. Followed babel guidelines to replace the old plugin by the latest `decorators-legacy`
Author
|
Btw I loved the trick of lowering the alpha to 50% for each import-cost default hex color option, now it is much less intrusive but still handy! This should be by default imho ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decorators-legacyThis fixes the "infamous" error, emitted by
@babel/parserand shown in the vscode output log:importCost error: SyntaxError: Decorators cannot be used to decorate parameters.Now it works as expected when decorators are declared as parameters:

Fixes: #161, Fixes: #164
Further information about the "decorators-legacy" option: https://babeljs.io/docs/en/babel-plugin-proposal-decorators (it seems also applicable to
@babel/parserplugin config)