Conversation
1. Break out the echoserver test into its own function, like the SFTP tests, called by the testsuite. 2. whitespace
There was a problem hiding this comment.
Pull request overview
This PR contains miscellaneous cleanup and enhancements including whitespace formatting improvements, a new channel type accessor function, and test suite refactoring to separate the echo server test into its own function.
Changes:
- Added
wolfSSH_ChannelGetType()accessor function to retrieve a channel's type name - Cleaned up whitespace and formatting in global request functions (
SendGlobalRequest,SendServiceRequest) - Refactored the test suite to extract echo server test logic into a dedicated
wolfSSH_EchoTest()function
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wolfssh/ssh.h | Added function declaration for wolfSSH_ChannelGetType() |
| src/ssh.c | Implemented wolfSSH_ChannelGetType() to return channel type name via IdToName() |
| src/internal.c | Fixed log message in SendGlobalRequest() and cleaned up whitespace/formatting |
| tests/testsuite.c | Extracted echo test into separate wolfSSH_EchoTest() function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Each channel has a type: session, forward, etc. Add an accessor to return the channel type for the specified channel.
1. Readjust the whitespace in the Global Request functions. 2. Remove redundant logging statements.
ejohnstown
force-pushed
the
misc-updates
branch
from
4bfdb17 to
ea45034
Compare
ejohnstown
force-pushed
the
misc-updates
branch
from
e53012b to
ea45034
Compare
JacobBarthelmeh
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A large PR had a few small unrelated changes in it. Separated them out into this PR.