feat: Add hybrid node/web dom parsing (NR-477)#24
Merged
lentil32 merged 10 commits intoian/nr-531from Jun 20, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lentil32
changed the title
Collaborator
Author
|
@maestrojeong 요걸 먼저 리뷰한 이후에 nr-531 봐주세요! |
lentil32
commented
Jun 18, 2025
Collaborator
Author
There was a problem hiding this comment.
node-html-parser 대신 jsdom 을 쓰면서 변경된 파일.
lentil32
commented
Jun 18, 2025
Comment on lines
+79
to
85
| const slimmedResult = pipe( | ||
| content, | ||
| p.parseHtml, | ||
| p.slimDocument, | ||
| (result) => result.slimmedHtml, | ||
| ); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
이런 API가 되었습니다
그냥 parseHtml, slimDocument 를 쓸 수도 있고
이렇게 FP로도 가능한 것..
maestrojeong
approved these changes
Jun 20, 2025
lentil32
added a commit
that referenced
this pull request
Jun 20, 2025
* refactor: Move footer to sole file * refactor: extract LLM tab into modular component architecture - Create shared atoms for state management (processedData, randomNumber, htmlId, feedbackSent, activeExtractTab) - Extract LLM logic into dedicated useLlm hook - Create reusable useFeedback hook for feedback functionality - Refactor LlmTab component to use atoms instead of props - Update MdrTab to use atoms for consistency - Create LlmInteractionSection wrapper component - Eliminate prop drilling throughout component hierarchy - Maintain feature parity while improving code organization 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: reset MDR state when changing files MDR results were persisting when switching between files. Now MDR state properly resets when: - Selecting a new file - Processing a file - Loading sample data - Fetching from URL Also simplified the code by removing the unnecessary resetMdr function and using direct atom setters instead. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: update docs * chore: remove unused files * feat: setup syncpack * CI: Update release.yml * chore: version up * feat: Add hybrid node/web dom parsing (NR-477) (#24) * feat: Add hybrid node/web dom parsing * feat: edit vercel timeout function * feat: add vercel timeout * feat: add slack webhook url as env * jsdom ground truth * refactor: Make node types as constant * feat: Update @wordbricks/next-eval API to FP friendly * chore: remove redundant file * choer: update package version --------- Co-authored-by: maestroJeong <legend4020@snu.ac.kr> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: maestroJeong <legend4020@snu.ac.kr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linkedom Advantages:
constants)
node-html-parser Disadvantages: