Stop to increase the score for banned IPs #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when an IP is already in the Block List, the plugin continues to increment its "Ban Score" for every new attempt. This was created in order to ban particularly persistent bots with different durations.
Proposed Change: I suggest modifying the logic so that if an IP is already banned, we simply reject the submission (block the request) without updating or increasing the ban score in the database.
The logic should follow this flow:
-> Yes -> Reject the request immediately
-> No -> increment the score
The score should remain static until the IP is removed from the Block List (either manually by the user or via the automatic score reduction cycle).
(OPTIONAL)
We should add a toggle in the Admin Panel to let the user decide this behavior. The option can be named "Continue increasing score for banned IPs" or something like that