Conversation
lizlooney
requested changes
Jan 26, 2026
| venv/ | ||
| *.egg-info | ||
|
|
||
| # oss attribution text file |
Collaborator
There was a problem hiding this comment.
Can you add a comment about why /oss-attribution/attribution.txt is specified here in .gitignore? Is it created when npm run start is run?
Collaborator
Author
There was a problem hiding this comment.
npx generate-attribution (from memory, may not be exactly correct) generates the attribution.txt and the license-infos.json file. (Same information - 2 different files)
It is an old program and you can't specify you only want one of the outputs. Choices were to either have our script delete the file or just put it in .gitignore. I chose the .gitignore route.
Collaborator
There was a problem hiding this comment.
Sure, that's fine. But please put a comment in .gitignore
lizlooney
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This not only updates the versions, but also simplifies things by getting rid of attribution.txt (since all of that info is repeated in licenseInfos.json)