Ask for class name (instead of module/file name) in dialog boxes#89
Merged
lizlooney merged 7 commits intowpilibsuite:mainfrom Mar 7, 2025
Merged
Ask for class name (instead of module/file name) in dialog boxes#89lizlooney merged 7 commits intowpilibsuite:mainfrom
lizlooney merged 7 commits intowpilibsuite:mainfrom
Conversation
…ewProjectNameModal.tsx.
…wModuleNameModal.tsx.
…s name. Show class names in the tree, instead of the module (file) names.
alan412
reviewed
Mar 7, 2025
src/modal/NewModuleNameModal.tsx
Outdated
|
|
||
| const DESCRIPTION = 'No spaces are allowed in the name. Each word in the name should start with a capital letter.'; | ||
|
|
||
| export const EXAMPLE_MECHANISM = 'For example, GamePieceShooter'; |
Collaborator
There was a problem hiding this comment.
Should this be:
For example: GamePieceShooter
alan412
reviewed
Mar 7, 2025
src/modal/NewModuleNameModal.tsx
Outdated
| const DESCRIPTION = 'No spaces are allowed in the name. Each word in the name should start with a capital letter.'; | ||
|
|
||
| export const EXAMPLE_MECHANISM = 'For example, GamePieceShooter'; | ||
| export const EXAMPLE_OPMODE = 'For example, AutoParkAndShoot'; |
Collaborator
There was a problem hiding this comment.
Should this be:
For example: AutoParkAndShoot
alan412
approved these changes
Mar 7, 2025
Collaborator
alan412
left a comment
alan412
left a comment
There was a problem hiding this comment.
I had two questions, but I am not sure I should be the authority on grammar in dialog boxes. You can merge it either way. I suspect when we get later in this project, we'll have people having lots of UI and text comments anyways.....
…face into pr_ask_for_class_name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57
Force class names to start with uppercase letter
Fixes #75
The new Project/OpMode/Mechanism dialog should ask for the class name (PascalCase)
Fixes #76
The tree should show the class names not the file names
Fixes #77
The Module class (in common_storage.ts) should have a field for className