Add changes to build repo using jdk21#4476
Open
chamilaadhi wants to merge 1 commit intowso2:4.11.xfrom
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
core/org.wso2.carbon.base/src/test/java/org/wso2/carbon/base/ServerConfigurationTest.java
Show resolved
Hide resolved
...org.wso2.carbon.bootstrap/src/main/java/org/wso2/carbon/bootstrap/CarbonSecurityManager.java
Show resolved
Hide resolved
core/org.wso2.carbon.bridge/src/main/java/org/wso2/carbon/bridge/FrameworkLauncherFactory.java
Show resolved
Hide resolved
Comment on lines
26
to
+28
| public void run() { | ||
| SecurityManager secMan = System.getSecurityManager(); | ||
| if (secMan != null) { | ||
| secMan.checkPermission(new ManagementPermission("control")); | ||
| } | ||
|
|
||
| // Carbon is running within an AppServer | ||
| FrameworkLauncher frameworkLauncher = FrameworkLauncherFactory.getFrameworkLauncher(); | ||
| frameworkLauncher.stop(); //TODO FIXME There is an Equinox memory leak which causes ChildFirstURLClassloader to remain alive | ||
| System.setProperty(FrameworkLauncher.START_TIME, String.valueOf(System.currentTimeMillis())); | ||
| frameworkLauncher.deploy(); | ||
| frameworkLauncher.start(); | ||
|
|
||
| // Carbon is running within an AppServer | ||
| FrameworkLauncher frameworkLauncher = FrameworkLauncherFactory.getFrameworkLauncher(); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 9
Suggested change
| public void run() { | |
| SecurityManager secMan = System.getSecurityManager(); | |
| if (secMan != null) { | |
| secMan.checkPermission(new ManagementPermission("control")); | |
| } | |
| // Carbon is running within an AppServer | |
| FrameworkLauncher frameworkLauncher = FrameworkLauncherFactory.getFrameworkLauncher(); | |
| frameworkLauncher.stop(); //TODO FIXME There is an Equinox memory leak which causes ChildFirstURLClassloader to remain alive | |
| System.setProperty(FrameworkLauncher.START_TIME, String.valueOf(System.currentTimeMillis())); | |
| frameworkLauncher.deploy(); | |
| frameworkLauncher.start(); | |
| // Carbon is running within an AppServer | |
| FrameworkLauncher frameworkLauncher = FrameworkLauncherFactory.getFrameworkLauncher(); | |
| public void run() { | |
| // Carbon is running within an AppServer | |
| log.info("Starting framework restart process"); | |
| FrameworkLauncher frameworkLauncher = FrameworkLauncherFactory.getFrameworkLauncher(); |
Comment on lines
+29
to
+32
| frameworkLauncher.stop(); //TODO FIXME There is an Equinox memory leak which causes ChildFirstURLClassloader to remain alive | ||
| System.setProperty(FrameworkLauncher.START_TIME, String.valueOf(System.currentTimeMillis())); | ||
| frameworkLauncher.deploy(); | ||
| frameworkLauncher.start(); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 10
Suggested change
| frameworkLauncher.stop(); //TODO FIXME There is an Equinox memory leak which causes ChildFirstURLClassloader to remain alive | |
| System.setProperty(FrameworkLauncher.START_TIME, String.valueOf(System.currentTimeMillis())); | |
| frameworkLauncher.deploy(); | |
| frameworkLauncher.start(); | |
| frameworkLauncher.stop(); //TODO FIXME There is an Equinox memory leak which causes ChildFirstURLClassloader to remain alive | |
| log.debug("Framework stopped successfully"); | |
| System.setProperty(FrameworkLauncher.START_TIME, String.valueOf(System.currentTimeMillis())); | |
| frameworkLauncher.deploy(); | |
| log.debug("Framework deployed successfully"); | |
| frameworkLauncher.start(); | |
| log.info("Framework restart completed successfully"); |
core/org.wso2.carbon.core/src/main/java/org/wso2/carbon/core/init/CarbonServerManager.java
Show resolved
Hide resolved
Comment on lines
+563
to
565
| CarbonCoreDataHolder.getInstance().addServiceRegistration(servletServiceRegistration); | ||
|
|
||
| if (filterServiceReference != null) { |
There was a problem hiding this comment.
Log Improvement Suggestion No: 12
Suggested change
| CarbonCoreDataHolder.getInstance().addServiceRegistration(servletServiceRegistration); | |
| if (filterServiceReference != null) { | |
| CarbonCoreDataHolder.getInstance().addServiceRegistration(servletServiceRegistration); | |
| log.info("Successfully registered CarbonServlet at path: " + servicePath + "/*"); | |
| if (filterServiceReference != null) { |
core/org.wso2.carbon.core/src/main/java/org/wso2/carbon/core/internal/CarbonCoreActivator.java
Show resolved
Hide resolved
Comment on lines
+176
to
+179
| public void addServiceRegistration(ServiceRegistration<?> serviceRegistration) { | ||
|
|
||
| serviceRegistrations.add(serviceRegistration); | ||
| } |
There was a problem hiding this comment.
Log Improvement Suggestion No: 15
Suggested change
| public void addServiceRegistration(ServiceRegistration<?> serviceRegistration) { | |
| serviceRegistrations.add(serviceRegistration); | |
| } | |
| public void addServiceRegistration(ServiceRegistration<?> serviceRegistration) { | |
| log.debug("Adding service registration to CarbonCoreDataHolder"); | |
| serviceRegistrations.add(serviceRegistration); | |
| } |
Comment on lines
+181
to
+186
| public void unregisterServiceRegistrations() { | ||
|
|
||
| for (ServiceRegistration<?> serviceRegistration : serviceRegistrations) { | ||
| serviceRegistration.unregister(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Log Improvement Suggestion No: 16
Suggested change
| public void unregisterServiceRegistrations() { | |
| for (ServiceRegistration<?> serviceRegistration : serviceRegistrations) { | |
| serviceRegistration.unregister(); | |
| } | |
| } | |
| public void unregisterServiceRegistrations() { | |
| log.info("Unregistering " + serviceRegistrations.size() + " service registrations"); | |
| for (ServiceRegistration<?> serviceRegistration : serviceRegistrations) { | |
| serviceRegistration.unregister(); | |
| } | |
| } |
core/org.wso2.carbon.core/src/main/java/org/wso2/carbon/core/transports/CarbonServlet.java
Show resolved
Hide resolved
core/org.wso2.carbon.core/src/main/java/org/wso2/carbon/core/transports/CarbonServlet.java
Show resolved
Hide resolved
...arbon.ndatasource.core/src/main/java/org/wso2/carbon/ndatasource/core/DataSourceService.java
Show resolved
Hide resolved
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.