Make parent type selected when fields are selected#1495
Make parent type selected when fields are selected#1495sachiniSam merged 1 commit intowso2:feature/persist-improvementsfrom
Conversation
📝 WalkthroughWalkthroughA new internal helper function Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@workspaces/ballerina/ballerina-side-panel/src/components/editors/DependentTypeEditor.tsx`:
- Around line 143-147: The comment above the block that sets member.selected is
misleading: replace it with a concise description that the guard checks whether
the member is optional (member.optional !== false) and that we set
member.selected to anyChildSelected so optional parents are selected when any
child is selected and deselected when no children are selected; reference the
symbols member, member.optional, member.selected, and anyChildSelected and
update the comment to reflect that the guard protects required fields
(non-optional) rather than "already-selected" parents.
workspaces/ballerina/ballerina-side-panel/src/components/editors/DependentTypeEditor.tsx
Outdated
Show resolved
Hide resolved
bf00dec to
481270b
Compare
6426cfd
into
wso2:feature/persist-improvements
Purpose
$subject
related issue wso2/product-ballerina-integrator#2042
Goals
Approach
UI Component Development
npm run storybookfrom the root directory to view current components.Manage Icons
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning
Summary by CodeRabbit