Add missing changes from feature/persistImprovements branch#1502
Add missing changes from feature/persistImprovements branch#1502sachiniSam merged 5 commits intowso2:release/bi-1.8.xfrom
Conversation
…into persistImprovements
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughRemoved experimental feature-flag and persistence checks from the Add Connection popup and deleted the ExperimentalBadge styled component; adjusted layout/padding and removed an extra wrapper in the ConnectionConfigurationPopup render. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
workspaces/ballerina/ballerina-visualizer/src/views/BI/Connection/AddConnectionPopup/AddConnectionPopupContent.tsx (1)
65-66:⚠️ Potential issue | 🟡 MinorRemove debug
console.logcalls before merging to release branch.Five
console.logstatements (lines 65–66, 99–100, 124) log raw backend payloads. These are debug artifacts that add noise and may expose internal data structures in production tooling.🧹 Proposed cleanup
- console.log(">>> bi connectors", model); - console.log(">>> bi filtered connectors", model.categories); setConnectors(model.categories);- console.log(">>> bi searched connectors", model); - console.log(">>> bi filtered connectors", model.categories); // When searching, the API might return a flat array...- console.log(">>> normalized categories for search", normalizedCategories); setConnectors(normalizedCategories);Also applies to: 99-100, 124-124
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@workspaces/ballerina/ballerina-visualizer/src/views/BI/Connection/AddConnectionPopup/AddConnectionPopupContent.tsx` around lines 65 - 66, Remove the debug console.log calls that print raw backend payloads in the AddConnectionPopupContent component (search for console.log(">>> bi connectors", model) and the other console.log lines printing model/categories/payload); either delete these statements or replace them with a proper debug-level logger behind an environment check (e.g., only log when DEBUG or NODE_ENV !== 'production') so no raw internal data is printed in production builds, and ensure removal/replacement is applied to all occurrences noted in the component (the three console.log sites).
🧹 Nitpick comments (1)
workspaces/ballerina/ballerina-visualizer/src/views/BI/Connection/AddConnectionPopup/AddConnectionPopupContent.tsx (1)
317-319:ConnectorOptionTitleContaineris now a superfluous wrapper.After removing
ExperimentalBadge,ConnectorOptionTitleContainerwraps a singleConnectorOptionTitlechild. The API-spec card at line 292 usesConnectorOptionTitledirectly without this container, creating an asymmetry. IfConnectorOptionTitleContainerapplies any flex/spacing styles intended for the badge layout, it may produce a subtle visual difference between the two cards.♻️ Proposed cleanup
- <ConnectorOptionTitleContainer> - <ConnectorOptionTitle>Connect to a Database</ConnectorOptionTitle> - </ConnectorOptionTitleContainer> + <ConnectorOptionTitle>Connect to a Database</ConnectorOptionTitle>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@workspaces/ballerina/ballerina-visualizer/src/views/BI/Connection/AddConnectionPopup/AddConnectionPopupContent.tsx` around lines 317 - 319, Remove the now-superfluous ConnectorOptionTitleContainer wrapper around ConnectorOptionTitle in AddConnectionPopupContent: replace the JSX that nests <ConnectorOptionTitle> inside <ConnectorOptionTitleContainer> with just <ConnectorOptionTitle> (matching the API-spec card usage), and if ConnectorOptionTitleContainer carried any layout styles needed for badge spacing, move those necessary styles into ConnectorOptionTitle or the parent card component so both cards render consistently; delete ConnectorOptionTitleContainer if it is no longer referenced elsewhere.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In
`@workspaces/ballerina/ballerina-visualizer/src/views/BI/Connection/AddConnectionPopup/AddConnectionPopupContent.tsx`:
- Around line 65-66: Remove the debug console.log calls that print raw backend
payloads in the AddConnectionPopupContent component (search for console.log(">>>
bi connectors", model) and the other console.log lines printing
model/categories/payload); either delete these statements or replace them with a
proper debug-level logger behind an environment check (e.g., only log when DEBUG
or NODE_ENV !== 'production') so no raw internal data is printed in production
builds, and ensure removal/replacement is applied to all occurrences noted in
the component (the three console.log sites).
---
Nitpick comments:
In
`@workspaces/ballerina/ballerina-visualizer/src/views/BI/Connection/AddConnectionPopup/AddConnectionPopupContent.tsx`:
- Around line 317-319: Remove the now-superfluous ConnectorOptionTitleContainer
wrapper around ConnectorOptionTitle in AddConnectionPopupContent: replace the
JSX that nests <ConnectorOptionTitle> inside <ConnectorOptionTitleContainer>
with just <ConnectorOptionTitle> (matching the API-spec card usage), and if
ConnectorOptionTitleContainer carried any layout styles needed for badge
spacing, move those necessary styles into ConnectorOptionTitle or the parent
card component so both cards render consistently; delete
ConnectorOptionTitleContainer if it is no longer referenced elsewhere.
sachiniSam
force-pushed
the
persistImprovements
branch
from
7b21a4f to
57021e0
Compare
3 participants
Purpose
Seems with the devant connection changes, some of the components have been removed and new component has been introduced, with this the changes which was present in feature branch is not present in release branch.
This pr adds those back in.
Also fixes some broken styles on connection form which caused with the devant changes
Goals
Approach
UI Component Development
npm run storybookfrom the root directory to view current components.Manage Icons
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning
Summary by CodeRabbit