Skip to content

Fix create new model provider action not being shown in form #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
senithkay merged 4 commits into from
Feb 24, 2026
Merged

Fix create new model provider action not being shown in form #1542

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d037a6
Fix create new model provider action not being shown in form
dan-niles Feb 24, 2026
8fa2ad1
Fix slider editor not showing in AI evaluation form
dan-niles Feb 24, 2026
2a4a71d
Add saving state management to AIEvaluationForm and TestFunctionForm
dan-niles Feb 24, 2026
4dc3398
Fix ACTION_EXPRESSION editors to use fieldInputType.fieldType
dan-niles Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion workspaces/ballerina/ballerina-side-panel/src/components/editors/EditorFactory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export const EditorFactory = (props: FormFieldEditorProps) => {
fieldInputType.fieldType === "RECORD_MAP_EXPRESSION" ||
fieldInputType.fieldType === "SQL_QUERY" ||
fieldInputType.fieldType === "NUMBER" ||
fieldInputType.fieldType === "PROMPT" ||
(fieldInputType.fieldType === "FLAG" && field.types?.length > 1)
)

Expand Down Expand Up @@ -178,7 +179,7 @@ export const EditorFactory = (props: FormFieldEditorProps) => {
/>
);

} else if (!field.items && fieldInputType.fieldType === "ACTION_EXPRESSION") {
} else if (!field.items && field.type === "ACTION_EXPRESSION") {
return (
<ActionExpressionEditor
field={field}
Expand Down
32 changes: 21 additions & 11 deletions workspaces/ballerina/ballerina-visualizer/src/views/BI/AIEvaluationForm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ export function AIEvaluationForm(props: TestFunctionDefProps) {
const [targetLineRange, setTargetLineRange] = useState<LineRange>();
const [dataProviderMode, setDataProviderMode] = useState<string>('evalSet');
const [evalsetOptions, setEvalsetOptions] = useState<Array<{ value: string; content: string }>>([]);
const [isSaving, setIsSaving] = useState<boolean>(false);

// Helper function to apply field visibility rules based on data provider mode
const applyFieldVisibility = (fields: FormField[], mode: string): FormField[] => {
Expand Down Expand Up @@ -234,7 +235,7 @@ export function AIEvaluationForm(props: TestFunctionDefProps) {
}

const onFormSubmit = async (data: FormValues, formImports: FormImports) => {
// Include the dataProviderMode from CardSelector state
setIsSaving(true);
const formData = {
...data,
dataProviderMode: dataProviderMode
Expand All @@ -245,16 +246,22 @@ export function AIEvaluationForm(props: TestFunctionDefProps) {
} else {
await rpcClient.getTestManagerRpcClient().addTestFunction({ function: updatedTestFunction, filePath });
}
const res = await rpcClient.getTestManagerRpcClient().getTestFunction(
{ functionName: updatedTestFunction.functionName.value, filePath });
const nodePosition = {
startLine: res.function.codedata.lineRange.startLine.line,
startColumn: res.function.codedata.lineRange.startLine.offset,
endLine: res.function.codedata.lineRange.endLine.line,
endColumn: res.function.codedata.lineRange.endLine.offset
};
rpcClient.getVisualizerRpcClient().openView(
{ type: EVENT_TYPE.OPEN_VIEW, location: { position: nodePosition, documentUri: filePath } })
try {
const res = await rpcClient.getTestManagerRpcClient().getTestFunction(
{ functionName: updatedTestFunction.functionName.value, filePath });
const nodePosition = {
startLine: res.function.codedata.lineRange.startLine.line,
startColumn: res.function.codedata.lineRange.startLine.offset,
endLine: res.function.codedata.lineRange.endLine.line,
endColumn: res.function.codedata.lineRange.endLine.offset
};
rpcClient.getVisualizerRpcClient().openView(
{ type: EVENT_TYPE.OPEN_VIEW, location: { position: nodePosition, documentUri: filePath } })
}
catch (error) {
console.error('Failed to open function in diagram:', error);
setIsSaving(false);
}
};

// Helper function to modify and set the visual information
Expand Down Expand Up @@ -307,6 +314,7 @@ export function AIEvaluationForm(props: TestFunctionDefProps) {
fields.push({
...generatedField,
type: 'SLIDER',
types: [{ fieldType: 'SLIDER', selected: false }],
sliderProps: {
min: 0,
max: 100,
Expand All @@ -323,6 +331,7 @@ export function AIEvaluationForm(props: TestFunctionDefProps) {
fields.push({
...generateFieldFromProperty('evalSetFile', evalSetFileField),
type: 'SINGLE_SELECT',
types: [{ fieldType: 'SINGLE_SELECT', selected: false }],
itemOptions: evalsetOptions
});
}
Expand Down Expand Up @@ -820,6 +829,7 @@ export function AIEvaluationForm(props: TestFunctionDefProps) {
onSubmit={onFormSubmit}
preserveFieldOrder={true}
onChange={handleFieldChange}
isSaving={isSaving}
injectedComponents={[
{
component: <CardSelector
Expand Down
30 changes: 19 additions & 11 deletions workspaces/ballerina/ballerina-visualizer/src/views/BI/TestFunctionForm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export function TestFunctionForm(props: TestFunctionDefProps) {
const [testFunction, setTestFunction] = useState<TestFunction>();
const [formTitle, setFormTitle] = useState<string>('Create New Test Case');
const [targetLineRange, setTargetLineRange] = useState<LineRange>();
const [isSaving, setIsSaving] = useState<boolean>(false);

const updateTargetLineRange = () => {
rpcClient
Expand Down Expand Up @@ -102,6 +103,7 @@ export function TestFunctionForm(props: TestFunctionDefProps) {
}

const onFormSubmit = async (data: FormValues, formImports: FormImports) => {
setIsSaving(true);
console.log("Test Function Form Data: ", data);
const updatedTestFunction = fillFunctionModel(data, formImports);
console.log("Test Function: ", updatedTestFunction);
Expand All @@ -110,17 +112,21 @@ export function TestFunctionForm(props: TestFunctionDefProps) {
} else {
await rpcClient.getTestManagerRpcClient().addTestFunction({ function: updatedTestFunction, filePath });
}
const res = await rpcClient.getTestManagerRpcClient().getTestFunction(
{ functionName: updatedTestFunction.functionName.value, filePath });
const nodePosition = {
startLine: res.function.codedata.lineRange.startLine.line,
startColumn: res.function.codedata.lineRange.startLine.offset,
endLine: res.function.codedata.lineRange.endLine.line,
endColumn: res.function.codedata.lineRange.endLine.offset
};
console.log("Node Position: ", nodePosition);
await rpcClient.getVisualizerRpcClient().openView(
{ type: EVENT_TYPE.OPEN_VIEW, location: { position: nodePosition, documentUri: filePath } })
try {
const res = await rpcClient.getTestManagerRpcClient().getTestFunction(
{ functionName: updatedTestFunction.functionName.value, filePath });
const nodePosition = {
startLine: res.function.codedata.lineRange.startLine.line,
startColumn: res.function.codedata.lineRange.startLine.offset,
endLine: res.function.codedata.lineRange.endLine.line,
endColumn: res.function.codedata.lineRange.endLine.offset
};
await rpcClient.getVisualizerRpcClient().openView(
{ type: EVENT_TYPE.OPEN_VIEW, location: { position: nodePosition, documentUri: filePath } })
} catch (error) {
console.error("Error opening test function in editor: ", error);
setIsSaving(false);
}
};

// Helper function to modify and set the visual information
Expand Down Expand Up @@ -173,6 +179,7 @@ export function TestFunctionForm(props: TestFunctionDefProps) {
fields.push({
...generatedField,
type: 'SLIDER',
types: [{ fieldType: 'SLIDER', selected: false }],
advanced: true,
sliderProps: {
min: 0,
Expand Down Expand Up @@ -603,6 +610,7 @@ export function TestFunctionForm(props: TestFunctionDefProps) {
targetLineRange={targetLineRange}
onSubmit={onFormSubmit}
preserveFieldOrder={true}
isSaving={isSaving}
/>
)}
</FormContainer>
Expand Down
Loading