More robust way of checking the browser type to fix Chrome 144+ issues#2049
Open
Igloczek wants to merge 1 commit intowxt-dev:mainfrom
Open
More robust way of checking the browser type to fix Chrome 144+ issues#2049Igloczek wants to merge 1 commit intowxt-dev:mainfrom
Igloczek wants to merge 1 commit intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
@Igloczek looks like Chrome fixed this on their side: #2039 (comment). I'm a little hesitant to make this change, it means people can't "reuse" a single extension build between multiple browsers and have it function the same way as before... but at the same time, I like this change. And I don't know how many people reuse builds between browsers (I would think very few, but not zero lol). Can you rebase it off the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Introduce more robust way of checking browser type, based on variables set during the build, instead of the runtime checks, to address the problems reported in #2039
Manual Testing
shouldn't return
undefinedin Chrome 144+Related Issue
#2039
This PR closes #2039