Skip to content

More robust way of checking the browser type to fix Chrome 144+ issues#2049

Open
Igloczek wants to merge 1 commit intowxt-dev:mainfrom
Igloczek:patch-1
Open

More robust way of checking the browser type to fix Chrome 144+ issues#2049
Igloczek wants to merge 1 commit intowxt-dev:mainfrom
Igloczek:patch-1

Conversation

@Igloczek
Copy link

Overview

Introduce more robust way of checking browser type, based on variables set during the build, instead of the runtime checks, to address the problems reported in #2039

Manual Testing

console.log(browser.devtools)

shouldn't return undefined in Chrome 144+

Related Issue

#2039

This PR closes #2039

@netlify
Copy link

netlify bot commented Jan 19, 2026

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 1f3ac94
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/696e6540269a800008f72f65
😎 Deploy Preview https://deploy-preview-2049--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aklinker1
Copy link
Member

@Igloczek looks like Chrome fixed this on their side: #2039 (comment).

I'm a little hesitant to make this change, it means people can't "reuse" a single extension build between multiple browsers and have it function the same way as before... but at the same time, I like this change. And I don't know how many people reuse builds between browsers (I would think very few, but not zero lol).

Can you rebase it off the major branch and target it in this PR? That way we can merge this into the next major release as a breaking change and ensure the change is documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

browser.devtools is undefined in Chrome 144

2 participants