fix: Add .jsonc support for locale files to match docs#2066
Merged
aklinker1 merged 2 commits intowxt-dev:mainfrom Feb 5, 2026
Merged
fix: Add .jsonc support for locale files to match docs#2066aklinker1 merged 2 commits intowxt-dev:mainfrom
.jsonc support for locale files to match docs#2066aklinker1 merged 2 commits intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2066 +/- ##
==========================================
- Coverage 76.25% 76.09% -0.17%
==========================================
Files 113 113
Lines 3049 3049
Branches 686 686
==========================================
- Hits 2325 2320 -5
- Misses 642 645 +3
- Partials 82 84 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.jsonc support for locale files
.jsonc support for locale files.jsonc support for locale files to match docs
Contributor
|
Thanks for helping make WXT better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added jsonc to allowed locale extensions. It was mentioned in documentation that jsonc extensions is supported but in reality there is an error. Looks like just missed here
Manual Testing
Create a locale in
<srcDir>/locales/<default_locale>.jsoncand you will notice that it simply crashes duringpreparestep withERROR [i18n] Required localization file does not exist: <localesDir>/en.{json|json5|yml|yaml|toml}. After fix it works as intended