Conversation
|
Hi, @SK-143381, A quick initial feedback. There is a pull request template that we will be using to gather more details about a PR, but it shows up only when you create the PR from GitHub. Please add the PR template and associated details to this PR. Please let me know if you want me to update the description with the template and if you want to update it later. Also, it's a good practice to have a GitHub issue associated with a PR for future reference. You can take a look at this PR for reference. Thanks. |
jooyoungseo
left a comment
jooyoungseo
left a comment
There was a problem hiding this comment.
@@SK-143381 -- Your example html does not work at all. Please follow the manual testing guide at https://github.com/uiuc-ischool-accessible-computing-lab/maidr/blob/9dc424f3c077a4529c51bbefdf975c8a13d9181d/ManualTestingProcess.md
And, create an issue to pinpoint what's not working.
jooyoungseo
left a comment
jooyoungseo
left a comment
There was a problem hiding this comment.
@@SK-143381 -- Your example html does not work at all. Please follow the manual testing guide at https://github.com/uiuc-ischool-accessible-computing-lab/maidr/blob/9dc424f3c077a4529c51bbefdf975c8a13d9181d/ManualTestingProcess.md
And, create an issue to pinpoint what's not working.
| }; | ||
| </script> | ||
|
|
||
| <script src="../src/js/maidr.js"></script> |
There was a problem hiding this comment.
Please see that the relative paths to the JS and CSS files are not correct.
|
|
||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <?xml version="1.0" encoding="utf-8" standalone="no"?> | ||
| <svg xmlns:xlink="http://www.w3.org/1999/xlink" width="460.8pt" height="345.6pt" viewBox="0 0 460.8 345.6" xmlns="http://www.w3.org/2000/svg" version="1.1"> |
There was a problem hiding this comment.
The SVG tags need and id and tab index. The same ID needs to be added to the maidr JS object.
jooyoungseo
force-pushed
the
main
branch
5 times, most recently
from
965dbcf to
184e8ed
Compare
3 participants
Added the html file to the scatter plot example