Energy Integration with discontinuous intrumental responses#624
Draft
Energy Integration with discontinuous intrumental responses#624
Conversation
In this draft, based on a mixing between pull requests #503 and #588, a different energy integrator has been tested, in the case of signals presenting bad quality data among good ones. As X-PSI is initially based on integration on continuous bins, the use of instrumental responses with "holes" is not adapted in the initial configuration, returning the response error related to the lack of positive values or the assertion errors related to the energies and channel edges. So a new version of the energy integrator is proposed here, with the edges designed into 2 arrays: one with the lower bounds and one with the upper bounds for each energy bin. Another extension is also given to enable X-PSI to use linear interpolation.
pstammler
requested review from
Basdorsman,
ckazantsev,
denis-gc,
drannawatts,
lmauviard,
sguillot and
thjsal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this draft, based on a mixing between pull requests #503 and #588, a different energy integrator has been tested, in the case of signals presenting bad quality data among good ones. As X-PSI is initially based on integration on continuous bins, the use of instrumental responses with "holes" is not adapted in the initial configuration, returning the response error related to the lack of positive values or the assertion errors related to the energies and channel edges. So a new version of the energy integrator is proposed here, with the edges designed into 2 arrays: one with the lower bounds and one with the upper bounds for each energy bin. Another extension is also given to enable X-PSI to use linear interpolation.