Fixed CapsLock triggering input twice in MacOS. #5282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Tyriar, when I use the terminal to input Chinese on MacOS, if I press CapsLock, it will trigger English input twice, but it should only trigger once. This PR fixes this problem.
Produce:
My processor is Mac M1 Pro, and this problem occurs in https://xtermjs.org and VS Code terminal, but I am surprised that no one has reported this problem. This has troubled me for a long time, I'm pretty sure this is a bug, because on the native terminal on MacOS, it behaves as expected. Looking forward to your reply.