Skip to content

feat: Implemented elicitation for tools to get the users data#28

Open
satvikbatra wants to merge 3 commits intomainfrom
feat/elicitation
Open

feat: Implemented elicitation for tools to get the users data#28
satvikbatra wants to merge 3 commits intomainfrom
feat/elicitation

Conversation

@satvikbatra
Copy link
Contributor

No description provided.

@satvikbatra satvikbatra requested a review from Copilot September 16, 2025 09:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements MCP (Model Context Protocol) elicitation functionality for JAF, enabling agents to request structured user input during tool execution. It adds comprehensive elicitation support including schema validation, provider management, and server endpoints.

Key Changes

  • Added core elicitation types and interfaces for request/response handling
  • Implemented ServerElicitationProvider for managing elicitation requests
  • Extended server API with elicitation endpoints and interruption handling

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/server/types.ts Added elicitation schemas and response types to server interfaces
src/server/server.ts Extended server with elicitation endpoints and interruption handling
src/server/index.ts Added default elicitation provider creation to server startup
src/index.ts Exported new elicitation modules for public API
src/core/types.ts Added core elicitation types and interruption definitions
src/core/engine.ts Integrated elicitation context and interruption handling into execution
src/core/elicitation.ts Implemented validation and utility functions for elicitation
src/core/elicitation-provider.ts Created in-memory provider for managing elicitation state
src/core/elicit.ts Added convenience functions and context management for tools
examples/elicitation-demo/ Complete demo with unit tests, server, and interactive client
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

…nagement and implement response cleanup mechanism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant