feat: Implemented elicitation for tools to get the users data#28
Open
satvikbatra wants to merge 3 commits intomainfrom
Open
feat: Implemented elicitation for tools to get the users data#28satvikbatra wants to merge 3 commits intomainfrom
satvikbatra wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements MCP (Model Context Protocol) elicitation functionality for JAF, enabling agents to request structured user input during tool execution. It adds comprehensive elicitation support including schema validation, provider management, and server endpoints.
Key Changes
- Added core elicitation types and interfaces for request/response handling
- Implemented ServerElicitationProvider for managing elicitation requests
- Extended server API with elicitation endpoints and interruption handling
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/server/types.ts | Added elicitation schemas and response types to server interfaces |
| src/server/server.ts | Extended server with elicitation endpoints and interruption handling |
| src/server/index.ts | Added default elicitation provider creation to server startup |
| src/index.ts | Exported new elicitation modules for public API |
| src/core/types.ts | Added core elicitation types and interruption definitions |
| src/core/engine.ts | Integrated elicitation context and interruption handling into execution |
| src/core/elicitation.ts | Implemented validation and utility functions for elicitation |
| src/core/elicitation-provider.ts | Created in-memory provider for managing elicitation state |
| src/core/elicit.ts | Added convenience functions and context management for tools |
| examples/elicitation-demo/ | Complete demo with unit tests, server, and interactive client |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…nagement and implement response cleanup mechanism
7fbbb18 to
e05de49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.