Skip to content

executor engine rebased #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
debajyoti0606 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

executor engine rebased #1210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3705c9b
service-init
Nov 11, 2025
1ab95b7
merge-tool-tables
Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server/api/knowledgeBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ export const CreateCollectionApi = async (c: Context) => {
},
{
retryLimit: 3,
expireInHours: 12,
expireInSeconds: 43200,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and maintainability, it's recommended to avoid using magic numbers. The value 43200 can be expressed as a calculation, which makes the intent clearer. This is consistent with the approach taken in server/api/oauth.ts (JobExpiryHours * 3600). This comment also applies to other occurrences of 43200 in this file.

        expireInSeconds: 12 * 60 * 60,

},
)
loggerWithChild({ email: userEmail }).info(
Expand Down Expand Up @@ -926,7 +926,7 @@ export const CreateFolderApi = async (c: Context) => {
},
{
retryLimit: 3,
expireInHours: 12,
expireInSeconds: 43200,
},
)

Expand Down Expand Up @@ -1076,7 +1076,7 @@ async function ensureFolderPath(
},
{
retryLimit: 3,
expireInHours: 12,
expireInSeconds: 43200,
},
)

Expand Down Expand Up @@ -1538,7 +1538,7 @@ export const UploadFilesApi = async (c: Context) => {
{ fileId: item.id, type: ProcessingJobType.FILE },
{
retryLimit: 3,
expireInHours: 12,
expireInSeconds: 43200,
},
)

Expand Down
2 changes: 1 addition & 1 deletion server/api/oauth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export const OAuthCallback = async (c: Context) => {
}
// Enqueue the background job within the same transaction
const jobId = await boss.send(SaaSQueue, SaasJobPayload, {
expireInHours: JobExpiryHours,
expireInSeconds: JobExpiryHours * 3600,
})
loggerWithChild({ email: email }).info(
`Job ${jobId} enqueued for connection ${connector.id}`,
Expand Down
Loading