fix: unknown-options-as-args should treat negated boolean as unknown when boolean-negation:false#509
Open
shadowspawn wants to merge 2 commits intoyargs:mainfrom
Open
fix: unknown-options-as-args should treat negated boolean as unknown when boolean-negation:false#509shadowspawn wants to merge 2 commits intoyargs:mainfrom
shadowspawn wants to merge 2 commits intoyargs:mainfrom
Conversation
…when boolean-negation:false
shadowspawn
force-pushed
the
fix-no-negated-with-unknown
branch
from
8620a5e to
f85e0c8
Compare
Member
Author
|
(Rebased.) |
Member
Author
|
I think a bogus CI failure, but was able to rerun jobs... Passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for
isUnknownOptionwas not taking configurationboolean-negationinto account.Fixes #376
Note: this code touches same lines as #508, and will need updating when that lands. [Edit: done]