IEC formatting: fix boundary selection, use constants, add tests#44
Merged
yashbhutwala merged 1 commit intomasterfrom Sep 10, 2025
Merged
IEC formatting: fix boundary selection, use constants, add tests#44yashbhutwala merged 1 commit intomasterfrom
yashbhutwala merged 1 commit intomasterfrom
Conversation
Owner
yashbhutwala
commented
Sep 10, 2025
yashbhutwala
commented
- Follow-up to Add decimals to output #29. Keeps decimal display but fixes unit boundary selection to use >= thresholds so exact powers render as 1Ki/1Mi/1Gi/1Ti.
- Replaces magic numbers with named byte-size constants (IEC and decimal).
- Adds unit tests covering boundary and fractional IEC cases.
… constants; add unit tests for IEC; bump k8s.io/cli-runtime to v0.20.0 for test/build compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.