Skip to content

dialect/sql: added checks for clauses which are not supported by YQL #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kprokopenko merged 2 commits into from
Dec 1, 2025
Merged

dialect/sql: added checks for clauses which are not supported by YQL #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d077dab
dialect/sql: added checks for clauses which are not supported by YQL
LostImagin4tion Nov 29, 2025
781989a
dialect/sql: fixed test
LostImagin4tion Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 60 additions & 35 deletions dialect/sql/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,11 @@ func (i *InsertBuilder) Values(values ...any) *InsertBuilder {

// Default sets the default values clause based on the dialect type.
func (i *InsertBuilder) Default() *InsertBuilder {
i.defaults = true
if i.ydb() {
i.AddError(fmt.Errorf("DEFAULT is not supported by %q", i.dialect))
} else {
i.defaults = true
}
return i
}

Expand Down Expand Up @@ -404,6 +408,10 @@ func ResolveWith(fn func(*UpdateSet)) ConflictOption {
// sql.ResolveWithNewValues()
// )
func (i *InsertBuilder) OnConflict(opts ...ConflictOption) *InsertBuilder {
if i.ydb() {
i.AddError(fmt.Errorf("ON CONFLICT is not supported by %q", i.dialect))
return i
}
if i.conflict == nil {
i.conflict = &conflict{}
}
Expand Down Expand Up @@ -486,13 +494,13 @@ func (i *InsertBuilder) QueryErr() (string, []any, error) {
switch {
case i.isUpsert:
if !b.ydb() {
b.AddError(fmt.Errorf("UPSERT INTO: unsupported dialect: %q", b.dialect))
b.AddError(fmt.Errorf("UPSERT INTO is not supported by %q", b.dialect))
return "", nil, b.Err()
}
b.WriteString("UPSERT INTO ")
case i.isReplace:
if !b.ydb() {
b.AddError(fmt.Errorf("REPLACE INTO: unsupported dialect: %q", b.dialect))
b.AddError(fmt.Errorf("REPLACE INTO is not supported by %q", b.dialect))
return "", nil, b.Err()
}
b.WriteString("REPLACE INTO ")
Expand Down Expand Up @@ -676,8 +684,8 @@ func (u *UpdateBuilder) Empty() bool {
// OrderBy appends the `ORDER BY` clause to the `UPDATE` statement.
// Supported by SQLite and MySQL.
func (u *UpdateBuilder) OrderBy(columns ...string) *UpdateBuilder {
if u.postgres() {
u.AddError(errors.New("ORDER BY is not supported by PostgreSQL"))
if u.postgres() || u.ydb() {
u.AddError(fmt.Errorf("ORDER BY is not supported by %q", u.dialect))
return u
}
for i := range columns {
Expand All @@ -689,8 +697,8 @@ func (u *UpdateBuilder) OrderBy(columns ...string) *UpdateBuilder {
// Limit appends the `LIMIT` clause to the `UPDATE` statement.
// Supported by SQLite and MySQL.
func (u *UpdateBuilder) Limit(limit int) *UpdateBuilder {
if u.postgres() {
u.AddError(errors.New("LIMIT is not supported by PostgreSQL"))
if u.postgres() || u.ydb() {
u.AddError(fmt.Errorf("LIMIT is not supported by %q", u.dialect))
return u
}
u.limit = &limit
Expand Down Expand Up @@ -724,7 +732,7 @@ func (u *UpdateBuilder) On(s *Selector) *UpdateBuilder {
if u.ydb() {
u.onSelect = s
} else {
u.AddError(fmt.Errorf("UPDATE ON: unsupported dialect: %q", u.dialect))
u.AddError(fmt.Errorf("UPDATE ON is not supported by %q", u.dialect))
}
return u
}
Expand All @@ -745,7 +753,7 @@ func (u *UpdateBuilder) QueryErr() (string, []any, error) {
// BATCH UPDATE (YDB-specific)
if u.isBatch {
if !b.ydb() {
b.AddError(fmt.Errorf("BATCH UPDATE: unsupported dialect: %q", b.dialect))
b.AddError(fmt.Errorf("BATCH UPDATE is not supported by %q", b.dialect))
return "", nil, b.Err()
}
if len(u.returning) > 0 {
Expand Down Expand Up @@ -846,8 +854,8 @@ func Delete(table string) *DeleteBuilder { return &DeleteBuilder{table: table} }
//
// Note: BATCH DELETE is only supported in YDB dialect.
//
// BatchDelete("/local/my_table")
// .Where(GT("Key1", 1))
// BatchDelete("/local/my_table").
// Where(GT("Key1", 1))
func BatchDelete(table string) *DeleteBuilder {
return &DeleteBuilder{table: table, isBatch: true}
}
Expand Down Expand Up @@ -886,7 +894,7 @@ func (d *DeleteBuilder) On(s *Selector) *DeleteBuilder {
if d.ydb() {
d.onSelect = s
} else {
d.AddError(fmt.Errorf("DELETE ON: unsupported dialect: %q", d.dialect))
d.AddError(fmt.Errorf("DELETE ON is not supported by %q", d.dialect))
}
return d
}
Expand All @@ -897,7 +905,7 @@ func (d *DeleteBuilder) Returning(columns ...string) *DeleteBuilder {
if d.ydb() {
d.returning = columns
} else {
d.AddError(fmt.Errorf("DELETE RETURNING: unsupported dialect: %q", d.dialect))
d.AddError(fmt.Errorf("DELETE RETURNING is not supported by %q", d.dialect))
}
return d
}
Expand All @@ -914,7 +922,7 @@ func (d *DeleteBuilder) QueryErr() (string, []any, error) {
// BATCH DELETE (YDB-specific)
if d.isBatch {
if !b.ydb() {
b.AddError(fmt.Errorf("BATCH DELETE: unsupported dialect: %q", b.dialect))
b.AddError(fmt.Errorf("BATCH DELETE is not supported by %q", b.dialect))
return "", nil, b.Err()
}
if len(d.returning) > 0 {
Expand Down Expand Up @@ -1323,6 +1331,8 @@ func (p *Predicate) NotIn(col string, args ...any) *Predicate {
}

// Exists returns the `Exists` predicate.
//
// Note: Correlated subqueries with EXISTS are not supported by YDB
func Exists(query Querier) *Predicate {
return P().Exists(query)
}
Expand All @@ -1338,6 +1348,8 @@ func (p *Predicate) Exists(query Querier) *Predicate {
}

// NotExists returns the `NotExists` predicate.
//
// Note: Correlated subqueries with NOT EXISTS are not supported by YDB
func NotExists(query Querier) *Predicate {
return P().NotExists(query)
}
Expand Down Expand Up @@ -1411,7 +1423,7 @@ func (p *Predicate) escapedLikeFold(col, left, substr, right string) *Predicate
// because this how it is defined in dialect/sql/schema.
b.Ident(col).WriteString(" COLLATE utf8mb4_general_ci LIKE ")
b.Arg(left + strings.ToLower(w) + right)
case dialect.Postgres:
case dialect.Postgres, dialect.YDB:
b.Ident(col).WriteString(" ILIKE ")
b.Arg(left + strings.ToLower(w) + right)
default: // SQLite.
Expand Down Expand Up @@ -1468,7 +1480,7 @@ func (p *Predicate) ColumnsHasPrefix(col, prefixC string) *Predicate {
p.WriteString(" ESCAPE ").Arg("\\")
}
default:
b.AddError(fmt.Errorf("ColumnsHasPrefix: unsupported dialect: %q", p.dialect))
b.AddError(fmt.Errorf("ColumnsHasPrefix is not supported by %q", p.dialect))
}
})
}
Expand Down Expand Up @@ -1815,7 +1827,7 @@ func (s *SelectTable) View(index string) *SelectTable {
if s.ydb() {
s.index = index
} else {
s.AddError(fmt.Errorf("VIEW: unsupported dialect: %q", s.dialect))
s.AddError(fmt.Errorf("VIEW is not supported by %q", s.dialect))
}
return s
}
Expand Down Expand Up @@ -2111,9 +2123,13 @@ func (s *Selector) From(t TableView) *Selector {

// AppendFrom appends a new TableView to the `FROM` clause.
func (s *Selector) AppendFrom(t TableView) *Selector {
s.from = append(s.from, t)
if st, ok := t.(state); ok {
st.SetDialect(s.dialect)
if s.ydb() && len(s.from) != 0 {
s.AddError(fmt.Errorf("multiple tables after FROM clause is not supported by %q", s.dialect))
} else {
s.from = append(s.from, t)
if st, ok := t.(state); ok {
st.SetDialect(s.dialect)
}
}
return s
}
Expand Down Expand Up @@ -2431,17 +2447,22 @@ func (s *Selector) UnionDistinct(t TableView) *Selector {

// Except appends the EXCEPT clause to the query.
func (s *Selector) Except(t TableView) *Selector {
s.setOps = append(s.setOps, setOp{
Type: setOpTypeExcept,
TableView: t,
})
if s.ydb() {
s.AddError(fmt.Errorf("EXCEPT is not supported by %q", s.dialect))
return s
} else {
s.setOps = append(s.setOps, setOp{
Type: setOpTypeExcept,
TableView: t,
})
}
return s
}

// ExceptAll appends the EXCEPT ALL clause to the query.
func (s *Selector) ExceptAll(t TableView) *Selector {
if s.sqlite() {
s.AddError(errors.New("EXCEPT ALL is not supported by SQLite"))
if s.sqlite() || s.ydb() {
s.AddError(fmt.Errorf("EXCEPT ALL is not supported by %q", s.dialect))
} else {
s.setOps = append(s.setOps, setOp{
Type: setOpTypeExcept,
Expand All @@ -2454,17 +2475,21 @@ func (s *Selector) ExceptAll(t TableView) *Selector {

// Intersect appends the INTERSECT clause to the query.
func (s *Selector) Intersect(t TableView) *Selector {
s.setOps = append(s.setOps, setOp{
Type: setOpTypeIntersect,
TableView: t,
})
if s.ydb() {
s.AddError(fmt.Errorf("INTERSECT is not supported by %q", s.dialect))
} else {
s.setOps = append(s.setOps, setOp{
Type: setOpTypeIntersect,
TableView: t,
})
}
return s
}

// IntersectAll appends the INTERSECT ALL clause to the query.
func (s *Selector) IntersectAll(t TableView) *Selector {
if s.sqlite() {
s.AddError(errors.New("INTERSECT ALL is not supported by SQLite"))
if s.sqlite() || s.ydb() {
s.AddError(fmt.Errorf("INTERSECT ALL is not supported by %q", s.dialect))
} else {
s.setOps = append(s.setOps, setOp{
Type: setOpTypeIntersect,
Expand Down Expand Up @@ -2616,8 +2641,8 @@ func WithLockClause(clause string) LockOption {
// For sets the lock configuration for suffixing the `SELECT`
// statement with the `FOR [SHARE | UPDATE] ...` clause.
func (s *Selector) For(l LockStrength, opts ...LockOption) *Selector {
if s.Dialect() == dialect.SQLite {
s.AddError(errors.New("sql: SELECT .. FOR UPDATE/SHARE not supported in SQLite"))
if s.sqlite() || s.ydb() {
s.AddError(fmt.Errorf("SELECT .. FOR UPDATE/SHARE is not supported by %q", s.dialect))
}
s.lock = &LockOptions{Strength: l}
for _, opt := range opts {
Expand Down Expand Up @@ -2754,7 +2779,7 @@ func (s *Selector) AssumeOrderBy(columns ...string) *Selector {

s.assumeOrder = append(s.assumeOrder, columns...)
} else {
s.AddError(fmt.Errorf("ASSUME ORDER BY: unsupported dialect: %q", s.dialect))
s.AddError(fmt.Errorf("ASSUME ORDER BY is not supported by %q", s.dialect))
}
return s
}
Expand Down
2 changes: 1 addition & 1 deletion dialect/sql/builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2598,7 +2598,7 @@ func TestSelectWithLock(t *testing.T) {
Where(EQ("id", 1)).
ForUpdate()
s.Query()
require.EqualError(t, s.Err(), "sql: SELECT .. FOR UPDATE/SHARE not supported in SQLite")
require.Contains(t, s.Err().Error(), "SELECT .. FOR UPDATE/SHARE is not supported")
}

func TestSelector_UnionOrderBy(t *testing.T) {
Expand Down
Loading