Skip to content

feat(TopicData): add pagination#3584

Open
Raubzeug wants to merge 4 commits intomainfrom
topic-data
Open

feat(TopicData): add pagination#3584
Raubzeug wants to merge 4 commits intomainfrom
topic-data

Conversation

@Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Mar 6, 2026

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
404 400 0 2 2
Test Changes Summary ✨1 🗑️4

✨ New Tests (1)

  1. Query streaming finishes in reasonable time (tenant/queryEditor/queryEditor.test.ts)

🗑️ Deleted Tests (4)

  1. Query streaming finishes with data (tenant/queryEditor/queryEditor.test.ts)
  2. Streaming query shows "Failed" status on server error (tenant/queryEditor/queryStatus.test.ts)
  3. Clicking a row opens query preview drawer (tenant/queryHistory/queryHistory.test.ts)
  4. Can save query from history using save button (tenant/queryHistory/queryHistory.test.ts)

Bundle Size: 🔺

Current: 62.96 MB | Main: 62.92 MB
Diff: +0.04 MB (0.06%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@Raubzeug
Copy link
Contributor Author

Raubzeug commented Mar 6, 2026

@greptile review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds pagination support to the TopicData diagnostics view to avoid rendering extremely large topic partitions at once and introduces a sticky footer area in the table layout for pagination controls.

Changes:

  • Added page-based navigation for large topic partitions (page size/threshold constants + UI pagination control).
  • Updated topic data fetching to support page-sized totals via a maxEntities cap.
  • Extended TableWithControlsLayout / PaginatedTableWithLayout to render a sticky footer section.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/containers/Tenant/Diagnostics/TopicData/utils/types.ts Adds currentPage to table filters to drive page refetching.
src/containers/Tenant/Diagnostics/TopicData/utils/constants.ts Introduces pagination sizing/threshold constants.
src/containers/Tenant/Diagnostics/TopicData/i18n/en.json Removes unused “last messages” description key.
src/containers/Tenant/Diagnostics/TopicData/getData.ts Adds maxEntities to cap reported totals for paginated pages.
src/containers/Tenant/Diagnostics/TopicData/TopicDataControls/TopicDataControls.tsx Removes truncated-data UI/prop and its help text.
src/containers/Tenant/Diagnostics/TopicData/TopicData.tsx Implements pagination state, page offset computations, and footer pagination control.
src/components/TableWithControlsLayout/TableWithControlsLayout.tsx Adds a new Footer slot component.
src/components/TableWithControlsLayout/TableWithControlsLayout.scss Adds sticky footer styling.
src/components/PaginatedTable/PaginatedTableWithLayout.tsx Wires optional footer into the standard table layout.

@Raubzeug Raubzeug marked this pull request as ready for review March 6, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Search by offset in topic doesn't work for >50 000 offsets in partition

2 participants