Open
Conversation
Contributor
Author
|
@greptile review |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds pagination support to the TopicData diagnostics view to avoid rendering extremely large topic partitions at once and introduces a sticky footer area in the table layout for pagination controls.
Changes:
- Added page-based navigation for large topic partitions (page size/threshold constants + UI pagination control).
- Updated topic data fetching to support page-sized totals via a
maxEntitiescap. - Extended
TableWithControlsLayout/PaginatedTableWithLayoutto render a sticky footer section.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/containers/Tenant/Diagnostics/TopicData/utils/types.ts | Adds currentPage to table filters to drive page refetching. |
| src/containers/Tenant/Diagnostics/TopicData/utils/constants.ts | Introduces pagination sizing/threshold constants. |
| src/containers/Tenant/Diagnostics/TopicData/i18n/en.json | Removes unused “last messages” description key. |
| src/containers/Tenant/Diagnostics/TopicData/getData.ts | Adds maxEntities to cap reported totals for paginated pages. |
| src/containers/Tenant/Diagnostics/TopicData/TopicDataControls/TopicDataControls.tsx | Removes truncated-data UI/prop and its help text. |
| src/containers/Tenant/Diagnostics/TopicData/TopicData.tsx | Implements pagination state, page offset computations, and footer pagination control. |
| src/components/TableWithControlsLayout/TableWithControlsLayout.tsx | Adds a new Footer slot component. |
| src/components/TableWithControlsLayout/TableWithControlsLayout.scss | Adds sticky footer styling. |
| src/components/PaginatedTable/PaginatedTableWithLayout.tsx | Wires optional footer into the standard table layout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ✨1 🗑️4
✨ New Tests (1)
🗑️ Deleted Tests (4)
Bundle Size: 🔺
Current: 62.96 MB | Main: 62.92 MB
Diff: +0.04 MB (0.06%)
ℹ️ CI Information