Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to update our proto dependency to use a couple new features:
... but we need to guard against new proto fields before updating proto dependency. E.g. we implicitly rely the only type of action is
Lock, but there are 2 new ones since the last time we bumped proto: https://github.com/Jorres/ydb-api-protos/blob/cc7e4c0e797abaab01eb30c6df8f5dd321d4359c/draft/protos/ydb_maintenance.proto#L146-L1474 changes in total:
GetLockAction() == nilchecks with panic (panic, noterr, because we are using solely lockc right now and wont be able to do anything if CMS suddently replies with a non-lock action. Later if we mix and match, e.g. with drain, I will implement proper runtime checks)CompleteActionsfor non-lock actions