Feature: Test refactor (No merge)#763
Draft
UlisesGascon wants to merge 17 commits intoyeoman:mainfrom
Draft
Conversation
- Replaced `--test-framework` argument in the initialization for prompts - Added new responses to global `this` following the current convention
As requested in #0599cc1a6845800bc0063c30b540b7dbc9fdbeb5
- Added test - Added tasks and dependencies to generated project - Added copy tasks to main writing task
- Babel config now supports modules (imp/exp) - Added module support in the index.html - Added sample function in main.js for future unit testing - Tests updated
This reverts commit 0b05190.
- Babel config now supports modules (imp/exp) - Added module support in the index.html - Added sample function in main.js for future unit testing - Tests updated
- Updated generator tests - Improved combined tests behaviour (e2e + unit) as single task - Added Jest sample test based in main.js' greetings function
- Updated generator tests - Added Ava sample test based in main.js' greetings function
😓 Sorry for that!
|
@UlisesGascon is this still something you're interested in? |
Member
|
To add to this, @UlisesGascon I just want to apologize, I have no idea how I missed this cool effort of yours! I'd gladly help with the tooling challenges if you'll be interested in continuing this. Also, pushing for ESM 6 years ago was very progressive of you 😮 |
Member
Author
I think that depends a lot if we want to keep this generator alive or not. So far seems like the plan is to archive it yeoman/yeoman#1779 but I am open to discuss it specially if the community want to support it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please, DO NOT merge it!
This is a working in progress feature. See #759
@silvenon... Let me share with you my approach for this feature.
app/scripts/main.jsthat exports a simple'\'Allo \'Allo!'text that is used already in the generator. The idea is to test this text in the several frameworks.What do you think?