Skip to content

Fix typo in test for Key#3856

Merged
WorldSEnder merged 1 commit intoyewstack:masterfrom
flumm:key-test-typo
May 21, 2025
Merged

Fix typo in test for Key#3856
WorldSEnder merged 1 commit intoyewstack:masterfrom
flumm:key-test-typo

Conversation

@flumm
Copy link
Contributor

@flumm flumm commented May 9, 2025

15_u64 and 15_u128 result in a duplicate, key, so change it to 16_u128.

Description

Just a typo fix in a test. Not sure if it would have real impact, but IMHO it's better to be on the safe side.

Checklist

  • I have reviewed my own code
  • I have added tests

15_u64 and 15_u128 result in a duplicate, key, so change it to 16_u128.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
@github-actions
Copy link

github-actions bot commented May 9, 2025

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)

✅ None of the examples has changed their size significantly.

@github-actions
Copy link

github-actions bot commented May 9, 2025

Visit the preview URL for this PR (updated for commit ad9f9f0):

https://yew-rs-api--pr3856-key-test-typo-vvc2w58z.web.app

(expires Fri, 16 May 2025 06:49:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented May 9, 2025

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.172 ns      │ 3.426 ns      │ 2.177 ns      │ 2.224 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.15 ns       │ 3.393 ns      │ 2.154 ns      │ 2.171 ns      │ 100     │ 1000000000

@github-actions
Copy link

github-actions bot commented May 9, 2025

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 288.475 291.492 290.794 0.871
Hello World 10 487.364 508.188 496.226 6.847
Function Router 10 1599.839 1618.527 1609.531 5.870
Concurrent Task 10 1005.021 1007.547 1006.520 0.698
Many Providers 10 1085.183 1186.648 1107.209 30.949

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 287.033 292.910 290.989 1.538
Hello World 10 484.919 496.047 490.446 3.258
Function Router 10 1632.539 1682.069 1645.127 14.725
Concurrent Task 10 1005.145 1007.179 1006.388 0.572
Many Providers 10 1107.158 1185.005 1125.236 23.147

Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Doesn't functionally do anything right now, as the result is not used, but useful for consistency and if key uniqueness is ever asserted at a higher level nonetheless.

@WorldSEnder WorldSEnder merged commit 122684b into yewstack:master May 21, 2025
32 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants