Merged
Conversation
15_u64 and 15_u128 result in a duplicate, key, so change it to 16_u128. Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
|
Visit the preview URL for this PR (updated for commit ad9f9f0): https://yew-rs-api--pr3856-key-test-typo-vvc2w58z.web.app (expires Fri, 16 May 2025 06:49:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
WorldSEnder
approved these changes
May 21, 2025
Member
WorldSEnder
left a comment
There was a problem hiding this comment.
Thanks! Doesn't functionally do anything right now, as the result is not used, but useful for consistency and if key uniqueness is ever asserted at a higher level nonetheless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
15_u64 and 15_u128 result in a duplicate, key, so change it to 16_u128.
Description
Just a typo fix in a test. Not sure if it would have real impact, but IMHO it's better to be on the safe side.
Checklist