Skip to content

Fix nightly lints#3857

Merged
WorldSEnder merged 4 commits intoyewstack:masterfrom
WorldSEnder:fix-nightly-lints
May 12, 2025
Merged

Fix nightly lints#3857
WorldSEnder merged 4 commits intoyewstack:masterfrom
WorldSEnder:fix-nightly-lints

Conversation

@WorldSEnder
Copy link
Member

Description

Fix some small issues that got caught in nightly CI.

Checklist

  • I have reviewed my own code

`feature(proc_macro_span)` has been partially stabilized in 1.89 (currently nightly) so
use it without feature config now.
github-actions[bot]
github-actions bot previously approved these changes May 12, 2025
@github-actions
Copy link

github-actions bot commented May 12, 2025

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock N/A 99.873 N/A N/A
boids N/A 168.625 N/A N/A
communication_child_to_parent N/A 92.548 N/A N/A
communication_grandchild_with_grandparent N/A 103.745 N/A N/A
communication_grandparent_to_grandchild N/A 99.771 N/A N/A
communication_parent_to_child N/A 89.486 N/A N/A
contexts N/A 104.240 N/A N/A
counter N/A 86.060 N/A N/A
counter_functional N/A 86.381 N/A N/A
dyn_create_destroy_apps N/A 89.193 N/A N/A
file_upload N/A 98.721 N/A N/A
function_memory_game N/A 170.977 N/A N/A
function_router N/A 337.767 N/A N/A
function_todomvc N/A 163.843 N/A N/A
futures N/A 236.771 N/A N/A
game_of_life N/A 107.097 N/A N/A
immutable N/A 194.975 N/A N/A
inner_html N/A 80.188 N/A N/A
js_callback N/A 107.687 N/A N/A
keyed_list N/A 196.339 N/A N/A
mount_point N/A 83.498 N/A N/A
nested_list N/A 112.915 N/A N/A
node_refs N/A 90.834 N/A N/A
password_strength N/A 1786.348 N/A N/A
portals N/A 92.799 N/A N/A
router N/A 306.472 N/A N/A
suspense N/A 111.686 N/A N/A
timer N/A 88.636 N/A N/A
timer_functional N/A 97.839 N/A N/A
todomvc N/A 143.830 N/A N/A
two_apps N/A 85.896 N/A N/A
web_worker_fib N/A 134.519 N/A N/A
web_worker_prime N/A 185.340 N/A N/A
webgl N/A 83.112 N/A N/A

✅ None of the examples has changed their size significantly.

@github-actions
Copy link

github-actions bot commented May 12, 2025

Visit the preview URL for this PR (updated for commit ada8bce):

https://yew-rs-api--pr3857-fix-nightly-lints-3bolzh1i.web.app

(expires Mon, 19 May 2025 16:43:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented May 12, 2025

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.124 ns      │ 2.334 ns      │ 2.126 ns      │ 2.131 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.151 ns      │ 2.217 ns      │ 2.153 ns      │ 2.156 ns      │ 100     │ 1000000000

@github-actions
Copy link

github-actions bot commented May 12, 2025

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 291.033 294.007 291.438 0.911
Hello World 10 491.688 497.597 494.212 1.639
Function Router 10 1624.886 1641.695 1629.372 5.026
Concurrent Task 10 1005.512 1007.628 1006.606 0.664
Many Providers 10 1086.597 1155.544 1102.922 20.922

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 290.947 291.537 291.192 0.184
Hello World 10 489.411 499.199 491.808 2.836
Function Router 10 1661.058 1674.490 1666.612 3.951
Concurrent Task 10 1005.140 1006.929 1006.042 0.551
Many Providers 10 1066.680 1081.483 1074.565 5.582

github-actions[bot]
github-actions bot previously approved these changes May 12, 2025
github-actions[bot]
github-actions bot previously approved these changes May 12, 2025
@WorldSEnder WorldSEnder merged commit a86c4f8 into yewstack:master May 12, 2025
25 checks passed
@WorldSEnder WorldSEnder deleted the fix-nightly-lints branch May 12, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant