Increase hydration test timeouts to fix flaky failures#3973
Merged
Madoshakalaka merged 1 commit intomasterfrom Jan 10, 2026
Merged
Increase hydration test timeouts to fix flaky failures#3973Madoshakalaka merged 1 commit intomasterfrom
Madoshakalaka merged 1 commit intomasterfrom
Conversation
The use_prepared_state and use_transitive_state hydration tests were flaky due to the async nature of base64 decoding via fetch API for data: URLs. The 100ms timeout was sometimes insufficient on CI runners under load. Increase timeouts from 100ms to 200ms to provide more headroom for the async hydration chain to complete.
|
Visit the preview URL for this PR (updated for commit b058c9f): https://yew-rs-api--pr3973-fix-flaky-hydration-xjb6l9oi.web.app (expires Thu, 15 Jan 2026 07:09:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we've been having flakey hydration tests for quite a few weeks.
Assertion failures look like:
We see failure modes show different stages of incomplete hydration too
This happens because client side decode is async:
It's a design choice:
#2650 (comment)