-
-
Notifications
You must be signed in to change notification settings - Fork 156
Fix deprecated tests in PHP 8.5.
#256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
terabytesoftw
commented
Feb 11, 2026
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Tests pass? | ❌ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
=========================================
Coverage 98.14% 98.14%
Complexity 268 268
=========================================
Files 16 16
Lines 756 756
=========================================
Hits 742 742
Misses 14 14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the test suite to avoid PHP 8.5-related deprecations/compatibility issues so the extension’s CI can run cleanly on newer PHP versions.
Changes:
- Adjusted the test helper
invoke()implementation intests/TestCase.php. - Updated
MessageTest::testHasCookies()to construct aCookiewith an explicitname. - Added a changelog entry for the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/TestCase.php | Alters the reflection-based helper used by many tests to call non-public methods. |
| tests/MessageTest.php | Updates cookie creation in a test to match newer expectations. |
| CHANGELOG.md | Records the test fixes in the project changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8.5.8.5.
8.5.8.5,
8.5,8.5.