This repository was archived by the owner on Aug 26, 2020. It is now read-only.
Emit github-verified-repo-event when web hooks signature passes muster.#6
Open
zee-roostify wants to merge 1 commit intoynab:masterfrom
Open
Emit github-verified-repo-event when web hooks signature passes muster.#6zee-roostify wants to merge 1 commit intoynab:masterfrom
github-verified-repo-event when web hooks signature passes muster.#6zee-roostify wants to merge 1 commit intoynab:masterfrom
Conversation
zee-roostify
force-pushed
the
allow-github-webhook-validator
branch
from
eaca215 to
71393ad
Compare
zee-roostify
changed the title
github-verified-repo-event when web hooks signature passes muster.
Author
|
I've altered my approach to extend the existing solution instead of altering the implementation, which allows people to listen for explicitly verified requests if they so desire. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on top of #5, I wanted to take a swing at verifying signatures without altering the built in src, to leave an example for other consumers who may want to do something similar but also don't want to host their own package.
Unfortunately, I wasn't quite able to do that, as the pull request setting signature headers to lower case (#2) wasn't merged in yet.
However, this is one way to get verified requests if people want.