Draft
Conversation
ysbaddaden
force-pushed
the
feature/add-timed-wait-to-cv
branch
from
82cbfe7 to
b77cbee
Compare
ysbaddaden
force-pushed
the
main
branch
2 times, most recently
from
a09c9ef to
d0d7cb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First attempt at adding timed waits to
Sync::CVso we can at most wait until some absolute monotonic deadline. Roughly follows the nsync algorithm though the wake/timeout semantics are different regarding crystal fibers (than system thread semaphores/futexes).Untested. Probably doesn't even compile. I think I got the logic right eventually, but I still need some more passes with a refreshed 🧠.Compiles and basic tests pass, but I eventually get a reproducible segfault so the logic ain't sound 💥Depends on RFC 0014 and crystal-lang/crystal#16070.
TODO:
Sync::CV#21.