Skip to content

Adding v41 and v42 into the code base#17

Open
syangdh wants to merge 1 commit intoyubin-park:masterfrom
syangdh:update-v41-and-v42
Open

Adding v41 and v42 into the code base#17
syangdh wants to merge 1 commit intoyubin-park:masterfrom
syangdh:update-v41-and-v42

Conversation

@syangdh
Copy link

@syangdh syangdh commented Jan 13, 2025

Hi @yubin-park ,

I stumble upon your DRG Grouper software and found it's very useful. First, thank you for your effort to put this great project together.

I found that V41 and V42 has been released since your last work, and I felt it would be wonderful we can take care of the new DRG dataset. So I create a PR trying to achieve it. If you have time, please review and see if it aligns with your long term vision of this project. I'd be happy to collaborate on this project if you need any help.

Copy link

@nvergos nvergos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid PR, especially appreciated the added README and comparison scripts. @yubin-park I recommend you merge to master

@tomdstone
Copy link

tomdstone commented Apr 2, 2025

Hello, I created a fork of this improvement, but it appears that the function appndxrdr.read_c errors on line 194074 of v42/appendix_C.txt, as the function does not appear to support parsing Appendix C Part 3. Is that an error that you are aware of?
Screenshot 2025-04-02 at 4 24 26 PM

@abdh1998
Copy link

@syangdh
thanks for for your job
you are added only the data there are any condition should added to logic for V41 , V42 ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants