Closed
Conversation
Contributor
Author
|
I thought to make a change like home-assistant/core#158063 in |
Owner
|
Thanks, but should no longer be needed with the latest commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


#377 had a build failure, this tries to fix it.
The situation
pycares 4.11.0 -> 5.0.0 (Dec 10) had breaking changes
We pull this in via:
homeassistant -> [aiohttp-asyncmdnsresolver ->] aiodns -> pycares
aiodns v3.6.1 (4 days ago) pinned pycares at "<5" aio-libs/aiodns@a85b558
Suggestions?
I'm not well versed in how python canon handles packages, the floating versions feels strange coming from C#.
Is there a better way to do this?