Skip to content

Fix build failure from #377#378

Closed
ndrwrbgs wants to merge 2 commits intozachowj:mainfrom
ndrwrbgs:build_fail
Closed

Fix build failure from #377#378
ndrwrbgs wants to merge 2 commits intozachowj:mainfrom
ndrwrbgs:build_fail

Conversation

@ndrwrbgs
Copy link
Contributor

@ndrwrbgs ndrwrbgs commented Dec 15, 2025

#377 had a build failure, this tries to fix it.

The situation

pycares 4.11.0 -> 5.0.0 (Dec 10) had breaking changes
We pull this in via:

homeassistant -> [aiohttp-asyncmdnsresolver ->] aiodns -> pycares

aiodns v3.6.1 (4 days ago) pinned pycares at "<5" aio-libs/aiodns@a85b558

Suggestions?

I'm not well versed in how python canon handles packages, the floating versions feels strange coming from C#.

Is there a better way to do this?

@ndrwrbgs
Copy link
Contributor Author

@ndrwrbgs ndrwrbgs marked this pull request as draft December 15, 2025 05:39
@ndrwrbgs ndrwrbgs marked this pull request as ready for review December 15, 2025 05:51
@ndrwrbgs
Copy link
Contributor Author

ndrwrbgs commented Dec 15, 2025

I thought to make a change like home-assistant/core#158063 in core, but notice that home-assistant/core@69c7a7b was already made; I'm not sure why it doesn't impact the dependency here

@zachowj
Copy link
Owner

zachowj commented Jan 3, 2026

Thanks, but should no longer be needed with the latest commits.

@zachowj zachowj closed this Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments