Feat: adding configurable parameter for custom role label in multiple resources#2802
Draft
idanovinda wants to merge 16 commits intomasterfrom
Draft
Feat: adding configurable parameter for custom role label in multiple resources#2802idanovinda wants to merge 16 commits intomasterfrom
idanovinda wants to merge 16 commits intomasterfrom
Conversation
idanovinda
added
the
major
|
hughcapet
reviewed
Nov 28, 2024
idanovinda
changed the title
Member
|
The PR is still WIP -- migration procedure needs to be implemented. See https://patroni.readthedocs.io/en/latest/kubernetes.html#customize-role-label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Spilo with Patroni 4.x integration: zalando/spilo#1050
This PR enhances operator to support Patroni 4.x while retaining compatibility with existing clusters by making the new role label configurable. The role terminology has changed from "master" to "primary". By default, Spilo will use the same value as before, which is
master. But to allow flexibility in label configurations, we need to ensure that the role label are configurable.This is achieved by adding configurable parameters:
pod_leader_label_value: default is set to "master"By setting this new configurable parameters to other value than default, it means that existing clusters need to be migrated to have the new role value. Migration hints from Patroni documentation: https://patroni.readthedocs.io/en/latest/kubernetes.html#customize-role-label