Skip to content

Consider container commands in Statefulset diffs#2971

Open
baarde wants to merge 2 commits intozalando:masterfrom
baarde:compare-container-commands
Open

Consider container commands in Statefulset diffs#2971
baarde wants to merge 2 commits intozalando:masterfrom
baarde:compare-container-commands

Conversation

@baarde
Copy link

@baarde baarde commented Oct 29, 2025

#2449 added Command to sidecars.

So container's commands should be compared when deciding whether a Statefulset has been updated.

@zalando-robot
Copy link

Cannot start a pipeline due to:

No accountable user for this pipeline: no Zalando employee associated to this GitHub username

Click on pipeline status check Details link below for more information.

@FxKu FxKu added this to the 1.16.0 milestone Dec 6, 2025
@FxKu FxKu requested a review from mikkeloscar as a code owner December 6, 2025 16:29
@mikkeloscar
Copy link
Member

Would be good to expand the test cases to cover this

@mortenlj
Copy link
Contributor

When a sidecar is defined in the OperatorConfiguration, all fields on the container may be specified. One commonly used would be args, it would probably be nice to compare those too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants