Draft
Conversation
Member
|
Oh nice! Will check it out asap :) |
Member
|
The colour/format seems fine (good even 😉). That's bottom of window not bottom of page right? |
Author
|
@kingthorin yeah I pulled the actual colors from the site on that one haha. Yeah bottom of the window. @psiinon any thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR is still a WIP. Right now the buttons are not functional.
- Summary
This PR adds a banner for cookie consent. Right now the site uses google analytics, this will allow users to opt out/in to being tracked with GA.
The banner was generated by this free tool from Osana.
If folks like the way it looks I can update the copy and work on connecting the buttons to functionality.
One nitpick from me is that I didn't like how after accepting/rejecting the cookie policy there is a floating tab at the bottom to re-open the cookie consent banner. I wish it would just go away. It is pretty small though so it's not too big a deal.
- Test plan
I tried running
npm run testbut there are no tests that are run! 🤷- Description for the changelog