internal/config/config.go: Do not save config when LAB_CORE_TOKEN is …#868
Draft
prarit wants to merge 1 commit intozaquestion:masterfrom
Draft
internal/config/config.go: Do not save config when LAB_CORE_TOKEN is …#868prarit wants to merge 1 commit intozaquestion:masterfrom
prarit wants to merge 1 commit intozaquestion:masterfrom
Conversation
…used @doronbehar reported a bug in lab where they specified LAB_CORE_TOKEN on the command line and then value was saved in the config file. Using LAB_CORE_TOKEN or LAB_CORE_HOST should not overwrite the config file. Do not save the config when LAB_CORE_TOKEN or LAB_CORE_HOST is specified. Closes zaquestion#868 Signed-off-by: Prarit Bhargava <prarit@redhat.com>
prarit
force-pushed
the
LAB_CORE_config_fix
branch
from
31436ce to
53344ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…used
@doronbehar reported a bug in lab where they specified LAB_CORE_TOKEN on the command line and then value was saved in the config file. Using LAB_CORE_TOKEN or LAB_CORE_HOST should not overwrite the config file.
Do not save the config when LAB_CORE_TOKEN or LAB_CORE_HOST is specified.