You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the codebase _iter_shard_regions was already falling back to chunks in case there are no shards. Another method, iter_shard_coords did not have this fallback option. This PR adds a fallback uption for that method in case there is no shard grid.
TODO:
Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.14%. Comparing base (ee0e69a) to head (eded573).
I see that, but do not see where this is used internally that it matters. Otherwise I would just provide the same fallback option for _iter_shard_coords and leave the original _iter_chunk intact.
I'm confused by these changes -- is there a bug that this fixes? Because we should already fall back to the chunk grid for unsharded v2 arrays, via the _shard_grid_shape property
Thanks @d-v-b for your patience and pointing it out. Was mainly based on spotting it based on the other method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs release notesAutomatically applied to PRs which haven't added release notes
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the codebase
_iter_shard_regionswas already falling back to chunks in case there are no shards. Another method,iter_shard_coordsdid not have this fallback option. This PR adds a fallback uption for that method in case there is no shard grid.TODO:
changes/@d-v-b @joshmoore