DOC: fix write_empty_chunks default claim in performance guide#3674
Open
RituDSML wants to merge 1 commit intozarr-developers:mainfrom
Open
DOC: fix write_empty_chunks default claim in performance guide#3674RituDSML wants to merge 1 commit intozarr-developers:mainfrom
RituDSML wants to merge 1 commit intozarr-developers:mainfrom
Conversation
github-actions
bot
added
the
needs release notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3666.
The performance guide states that
write_empty_chunks=Trueis “the default”, but the actual runtime configuration default isFalse(e.g.zarr.config.get("array.write_empty_chunks")). This PR removes the incorrect default claim to keep the documentation consistent with the implementation.