lift async array methods to stand-alone functions#3676
Open
d-v-b wants to merge 5 commits intozarr-developers:mainfrom
Open
lift async array methods to stand-alone functions#3676d-v-b wants to merge 5 commits intozarr-developers:mainfrom
d-v-b wants to merge 5 commits intozarr-developers:mainfrom
Conversation
github-actions
bot
added
the
needs release notes
…ore/dissolve-async-array
Contributor
Author
|
this is ready for review. this is a purely internal refactor that shouldn't affect anything at runtime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes the bulk of the
AsyncArraymethods and delegates them to stand-alone functions. This makes the core functionality like reading chunks, writing chunks, resizing, appending, etc, possible without creating anAsyncArray.A set of focused, independent functions is a much stronger API foundation than a single object.
Opening as a draft for discussion -- for example, should we have
_syncversions of all these new functions?