Skip to content

zbm-builder.sh: Use -d for custom container CLI #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noelleleigh wants to merge 4 commits into
base: master
Choose a base branch
from
Open

zbm-builder.sh: Use -d for custom container CLI #808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d32d72
zbm-builder.sh: Use -d for custom container CLI
noelleleigh Feb 5, 2026
671f3ae
docs: adjust wording in container-building.rst
noelleleigh Feb 6, 2026
05e7bd2
zbm-builder.sh: Reword -d help text
noelleleigh Feb 6, 2026
79c7e6e
zbm-builder.sh: Reword error when PODMAN can't be found
noelleleigh Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/general/container-building.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ Dependencies
------------

To build ZFSBootMenu images from a build container, either `podman <https://podman.io>`_ or
`docker <https://www.docker.com>`_ is required. The development team prefers ``podman``, but ``docker`` may generally be
substituted without consequence.
`docker <https://www.docker.com>`_ is required. The development team prefers ``podman``, but ``docker`` or a
compatible container utility may generally be substituted without consequence.

If a custom build container is desired, `buildah <https://buildah.io>`_ and ``podman`` are generally required. A
:zbm:`Dockerfile <releng/docker/Dockerfile>` is provided for convenience, but feature parity with the ``buildah``
Expand Down
10 changes: 6 additions & 4 deletions zbm-builder.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ OPTIONS:
Specify the path to a configuration file that will be sourced
(Default: \${BUILD_DIRECTORY}/zbm-builder.conf, if it exists)

-d Force use of docker instead of podman
-d <container-frontend>
Use the specified front-end utility to launch the build container
(Default: podman if available, docker otherwise)

-M <argument>
Provide a comma-separated list of options to use for volume
Expand Down Expand Up @@ -119,7 +121,7 @@ else
PODMAN="docker"
fi

CMDOPTS="b:dhi:l:L:c:M:O:HR"
CMDOPTS="b:d:hi:l:L:c:M:O:HR"

# First pass to get build directory and configuration file
while getopts "${CMDOPTS}" opt; do
Expand Down Expand Up @@ -166,7 +168,7 @@ while getopts "${CMDOPTS}" opt; do
b|c|h)
;;
d)
PODMAN=docker
PODMAN="${OPTARG}"
;;
i)
BUILD_IMG="${OPTARG}"
Expand Down Expand Up @@ -202,7 +204,7 @@ done
shift $((OPTIND-1))

if ! command -v "${PODMAN}" >/dev/null 2>&1; then
echo "ERROR: this script requires podman or docker"
echo "ERROR: ${PODMAN} not found; use '-d' to specify a container front-end"
exit 1
fi

Expand Down