[book] Fix p_poly to match implementation; specify synthetic blinding factor f construction#777
Open
therealyingtong wants to merge 8 commits intomainfrom
Open
[book] Fix p_poly to match implementation; specify synthetic blinding factor f construction#777therealyingtong wants to merge 8 commits intomainfrom
p_poly to match implementation; specify synthetic blinding factor f construction#777therealyingtong wants to merge 8 commits intomainfrom
Conversation
p_poly is constructed as a linear combination of q_prime and the q_polys in steps 18 and 19 of the protocol description.
p_poly in protocol to match implementationp_poly in protocol to match implementation
p_poly in protocol to match implementationp_poly in protocol to match implementation
daira
reviewed
May 22, 2023
daira
approved these changes
May 22, 2023
Contributor
daira
left a comment
There was a problem hiding this comment.
ACK with non-blocking suggestion; doc-only.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Daira Hopwood <daira@jacaranda.org> Co-authored-by: str4d <jack@electriccoin.co>
daira
approved these changes
May 24, 2023
Merged
p_poly in protocol to match implementationp_poly to match implementation; specify synthetic blinding factor f construction
daira
reviewed
Jun 2, 2023
daira
approved these changes
Jun 2, 2023
Contributor
daira
left a comment
There was a problem hiding this comment.
ACK with nonblocking suggestions.
Co-authored-by: Lasse Bramer Schmidt <lasse@lasses-air.eduroam.net.au.dk>
daira
reviewed
Jun 6, 2023
daira
reviewed
Jun 6, 2023
daira
reviewed
Jun 6, 2023
daira
reviewed
Jun 6, 2023
daira
reviewed
Jun 6, 2023
daira
reviewed
Jun 6, 2023
daira
reviewed
Jun 6, 2023
daira
reviewed
Jun 6, 2023
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
therealyingtong
commented
Jun 27, 2023
book/src/design/protocol.md
Outdated
| * Starting at $i=0$ and ending at $n_a - 1$ $\prover$ sets $q_{\sigma(i)} := x_1 q_{\sigma(i)} + a'(X)$. | ||
| 12. $\prover$ initializes $q_0(X), q_1(X), ..., q_{n_q - 1}(X) = 0$ and blinding factors $q^*_0, q^*_1, ..., q^*_{n_q-1} = 0$. | ||
| * Starting at $i=0$ and ending at $n_a - 1$ $\prover$ sets $q_{\sigma(i)} := x_1 q_{\sigma(i)} + a'(X)$ and $q^*_{\sigma(i)} := x_1 q^*_{\sigma(i)} + a^*_i$. | ||
| * $\prover$ finally sets $q_0(X) := x_1^2 q_0(X) + x_1 h'(X) + r(X)$. |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| * $\prover$ finally sets $q_0(X) := x_1^2 q_0(X) + x_1 h'(X) + r(X)$. | |
| * $\prover$ finally sets $q_0(X) := x_1^2 q_0(X) + x_1 h'(X) + r(X)$ and $q^*_0 := x_1^2 q^*_0 + x_1 h'^* + r^*$. |
book/src/design/protocol.md
Outdated
| * $\prover$ sends a hiding commitment $A_j = \innerprod{\mathbf{a'}}{\mathbf{G}} + [a^*_j] W$ where $\mathbf{a'}$ are the coefficients of the univariate polynomial $a'_j(X)$ and $a^*_j$ is some random, independently sampled blinding factor. (Similar notation is used throughout this protocol description, if the value is not reused we will use $\cdot$ to simplify exposition.) | ||
| * $\verifier$ responds with a challenge $c_j$. | ||
| 2. $\prover$ sets $g'(X) = g(X, c_0, c_1, ..., c_{n_a - 1}, \cdots)$. | ||
| 3. $\prover$ sends a commitment $R = \innerprod{\mathbf{r}}{\mathbf{G}} + [\cdot] W$ where $\mathbf{r} \in \field^n$ are the coefficients of a randomly sampled univariate polynomial $r(X)$ of degree $n - 1$. |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| 3. $\prover$ sends a commitment $R = \innerprod{\mathbf{r}}{\mathbf{G}} + [\cdot] W$ where $\mathbf{r} \in \field^n$ are the coefficients of a randomly sampled univariate polynomial $r(X)$ of degree $n - 1$. | |
| 3. $\prover$ sends a commitment $R = \innerprod{\mathbf{r}}{\mathbf{G}} + [r^*] W$ where $\mathbf{r} \in \field^n$ are the coefficients of a randomly sampled univariate polynomial $r(X)$ of degree $n - 1$. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p_polyis constructed as a linear combination of q_prime and the q_polys in steps 18 and 19 of the protocol description. Previously, the expression used in the protocol description did not match the implementation:halo2/halo2_proofs/src/poly/multiopen/prover.rs
Lines 105 to 113 in 5678a50
halo2/halo2_proofs/src/poly/multiopen/verifier.rs
Lines 120 to 129 in 5678a50