Document z_en_xc.c and csdis.py changes#2692
Conversation
| /* 0x77 */ CS_DEST_ZELDAS_COURTYARD_RECEIVE_LETTER | ||
| } CutsceneDestination; | ||
|
|
||
| typedef enum EnXcCueId { |
There was a problem hiding this comment.
since these are actor-specific I think it would make more sense to place them in the actor overlay header (if possible), I'm worried we'll end up with lots of actor-specific enums like this as more actor cues are documented in the future
There was a problem hiding this comment.
oh nvm I should learn how to read lol
I wouldn't be against having a separate header for actor-specific cutscene stuff, like instead of having them in z_en_xc.h directly we could make another file in that folder for this
There was a problem hiding this comment.
Personally I'd like to hold off until more asset splitting and cutscene documentation happens before deciding how to sort things.
| /* 00 */ SHEIK_ACTION_0_TEACH1_CHECK_DEMO_START, | ||
| /* 01 */ SHEIK_ACTION_1_TEACH1_INVISIBLE, | ||
| /* 02 */ SHEIK_ACTION_2_TEACH1_GRACEFUL_FALL, |
There was a problem hiding this comment.
What's the purpose in keeping the numerical value in the enum name?
3 participants
Contributions made in this pr are licensed under CC0
Some important bullets:
actor_cue_id_tablein csdis.py for outputting named enums for individual actor cue ids. I've set it up so that for actor cues, the CutsceneCommand id is equivalent to the enum_no for the cue id enumeration.ActorMovement_func_functions. I've just given them temp names to sort of make them more readable for now.cutscenes.hbecause there isn't a way to import them where required atm.