Skip to content

Conversation

@octaviusz
Copy link
Contributor

This PR introduces the ability to create or extend split views by dragging and dropping a link. The placement of the new split tab is determined by the drop location on the target area, allowing for intuitive directional splitting.

recording_2025-06-01_21.53.05.mp4

@octaviusz octaviusz requested a review from mr-cheffy June 1, 2025 18:58
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Feature labels Jun 1, 2025
Copy link
Member

@mr-cheffy mr-cheffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@octaviusz octaviusz force-pushed the drop-link-to-split branch from a0a11da to d8910be Compare June 1, 2025 21:04
@octaviusz octaviusz requested a review from mr-cheffy June 3, 2025 12:10
Copy link
Member

@mr-cheffy mr-cheffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes! I was wondering if you could also write tests for these. It's fine if you can't, don't worry.

@octaviusz octaviusz requested a review from mr-cheffy June 7, 2025 14:32
@LemonPotion
Copy link

@mr-cheffy , can you review this pr? I think the @octaviusz resolved all of the issues.

Thank you for your hard work❤️

@mr-cheffy
Copy link
Member

Yeah, it'll be merged on the next release cycle

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 18, 2025
@octaviusz octaviusz marked this pull request as draft December 18, 2025 15:37
@octaviusz
Copy link
Contributor Author

recording_2025-12-18_18.38.37.mp4

PR isn't dead, but it needs a little touch up. I think I'll be done soon.

@alpegasus
Copy link

recording_2025-12-18_18.38.37.mp4

PR isn't dead, but it needs a little touch up. I think I'll be done soon.

That looks polished, thanks for touching it up & sharing the video! Excited to use it.

@octaviusz octaviusz closed this Jan 20, 2026
@octaviusz octaviusz deleted the drop-link-to-split branch January 20, 2026 08:40
@mr-cheffy
Copy link
Member

@octaviusz why close?

@octaviusz octaviusz restored the drop-link-to-split branch January 20, 2026 10:07
@octaviusz octaviusz reopened this Jan 20, 2026
@octaviusz
Copy link
Contributor Author

@mr-cheffy I accidentally deleted the branch

@octaviusz octaviusz marked this pull request as ready for review February 8, 2026 22:13
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Feb 9, 2026
@octaviusz octaviusz requested a review from mr-cheffy February 9, 2026 14:47
@octaviusz
Copy link
Contributor Author

#12320

@octaviusz octaviusz closed this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants