-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Drag and Drop link to split #8773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mr-cheffy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
a0a11da to
d8910be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes! I was wondering if you could also write tests for these. It's fine if you can't, don't worry.
Signed-off-by: mr. m <91018726+mauro-balades@users.noreply.github.com>
Signed-off-by: mr. m <91018726+mauro-balades@users.noreply.github.com>
|
@mr-cheffy , can you review this pr? I think the @octaviusz resolved all of the issues. Thank you for your hard work❤️ |
|
Yeah, it'll be merged on the next release cycle |
recording_2025-12-18_18.38.37.mp4PR isn't dead, but it needs a little touch up. I think I'll be done soon. |
That looks polished, thanks for touching it up & sharing the video! Excited to use it. |
|
@octaviusz why close? |
|
@mr-cheffy I accidentally deleted the branch |
This PR introduces the ability to create or extend split views by dragging and dropping a link. The placement of the new split tab is determined by the drop location on the target area, allowing for intuitive directional splitting.
recording_2025-06-01_21.53.05.mp4