Customizable Tables#401
Open
Vac1911 wants to merge 48 commits intozengm-games:masterfrom
Vac1911:master
Open
Conversation
added 3 commits
December 8, 2021 16:03
dumbmatter
reviewed
Dec 9, 2021
Member
dumbmatter
left a comment
dumbmatter
left a comment
There was a problem hiding this comment.
This is only a partial review, there will be more! It's just all I have time for right now. If we succeed in merging this, it will probably take a while :)
Also can you give me commit access to your repo? I'm not going to do anything crazy (at least not without telling you) but I will probably need to do something at some point.
Author
|
sent you an invite to the repo |
added 7 commits
December 9, 2021 13:38
dumbmatter
reviewed
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just spent 3 hours writing a pull request then my computer crashed so this is gonna be a TLDR version:
Look I made it so you can change what columns tables have:
and you can reorder them with drag and drop easily
Currently I've only "upgraded" the "normal" tables which show a list of player as a starting point (so like freeAgents, tradingBlock, playerStats, etc.). Next steps in my mind would be to do gamelog, player view, and roster pages. The first 2 have data being pulled from other places than player, and roster isnt using the DataTable component currently.
After that team tables could be upgraded such as teamStats() but besides that there arent many tables displaying the same things, which would mean making templates for them would be somewhat redundant as they dont need to be shared.