Open
Conversation
1db80b5 to
4a7a8fc
Compare
4edf3e5 to
a7f4029
Compare
926ac37 to
8eeb6f7
Compare
8eeb6f7 to
6dc63a3
Compare
5ea8bea to
aa6f2b8
Compare
525d61b to
3093812
Compare
1 task
bcdurak
reviewed
Jan 26, 2026
Contributor
bcdurak
left a comment
There was a problem hiding this comment.
What a complicated but beautifully crafted piece of code <3
I am leaving a few comments to start with, and I will take another look into the runner tomorrow. Since it touches upon the main orchestrators, I feel like a small test session would be nice. Which ones have you tested so far?
| logger.info("Waiting for AzureML job `%s` to finish...", job.name) | ||
| ml_client.jobs.stream(job.name) | ||
| logger.info("AzureML job `%s` completed.", job.name) | ||
| publish_step_run_metadata( |
Contributor
There was a problem hiding this comment.
I am just going to leave a small comment here. In our case, I don't think it is a big problem, but wanted to mention just in case. There are scenarios where this call might skip the creation of certain metadata without failing (data too large, or unsupported type), in which case, there might be a drift between the step_run in the info and in the DB.
01aef69 to
96ab3f8
Compare
bcdurak
approved these changes
Jan 30, 2026
3bde83c to
4995575
Compare
cb8f1d2 to
327433d
Compare
327433d to
8f66546
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe changes
This PR updates the way isolated steps are executed and monitored in dynamic pipelines.
Previously, it worked as follows: When the user decided to run an isolated step, we would call an orchestrator method that would launch the step and then wait for the step to finish before returning. This meant that the thread was blocked for the entire duration.
With this PR, the submitting of an isolated step is now separated from the monitoring. When an isolated step needs to be run, the orchestrator submits that steps to its backend. After that, the thread is freed up and can be used to launch other steps. The monitoring of all isolated steps happens in a single thread that is just responsible for the monitoring.
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes