Skip to content

feat: add output path cli arg. change: copying and removing cache/out files#8

Open
carafelix wants to merge 4 commits intozeph1rus:mainfrom
carafelix:main
Open

feat: add output path cli arg. change: copying and removing cache/out files#8
carafelix wants to merge 4 commits intozeph1rus:mainfrom
carafelix:main

Conversation

@carafelix
Copy link

@carafelix carafelix commented Oct 27, 2025

closes #7

this PR changes the following:

  • Add output path as a CLI arg
  • Change default behavior to not clearing the output dir
  • Add --clear-out flag for clearing the output dir, limits it to just .mp3 and .m3u files
  • Copy files from cache to output as their are being downloaded
  • Add --clear-cache flag, remove cached files as their are being copied to the output dir

@carafelix carafelix changed the title fix: #7, adds output cli arg fix: #7, adds output path cli arg Oct 27, 2025
@carafelix carafelix marked this pull request as draft October 27, 2025 21:03
@carafelix carafelix marked this pull request as ready for review October 27, 2025 21:09
@carafelix carafelix marked this pull request as draft October 27, 2025 21:18
@zeph1rus
Copy link
Owner

I do really appreciate you taking the time to work on this, for the reasons I put on on #7 I'm not going to merge this as it is, sorry

@carafelix carafelix marked this pull request as ready for review October 27, 2025 21:43
@carafelix carafelix changed the title fix: #7, adds output path cli arg feat: add output path cli, sequential copying and rm of files Oct 27, 2025
@carafelix
Copy link
Author

@zeph1rus I reintroduced the clearance of the output dir as a flag. Consider merging 👍

@carafelix carafelix changed the title feat: add output path cli, sequential copying and rm of files feat: add output path cli arg. change: copying and removing cache/out files Oct 27, 2025
@zeph1rus
Copy link
Owner

@carafelix There's a wider problem with numbering the files on subsequent runs, the way things are you'd end up with files with non unique or sequential numbers as pods get added - not your fault or problem, it's a requirement for my use cases. I'm pretty sure I know how I want to do that.

How do you want to handle that, would you like me to make the changes to make that work, and then you can rebase and put your changes on top, or you would you be ok with me adding some of the changes you made into that?

@carafelix
Copy link
Author

carafelix commented Oct 29, 2025

or you would you be ok with me adding some of the changes you made into that?

I think best case is you do that branching from this? idk

Maybe merge this into somewhat like next, branch, do your changes and merge that into main?

Whatever suits your needs tbh. I'm okay with whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRITICAL: Removing all files in the output directory could lead to disaster

2 participants