-
-
Notifications
You must be signed in to change notification settings - Fork 63
Basis optimization CLI #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
1daf5e8
83a6aab
5e99196
fd4469e
be064dd
cb85646
65de7d6
d900425
ec336e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,10 +29,11 @@ | |
| subp = p.add_subparsers(title="Commands") | ||
|
|
||
| get_argparse_parser( | ||
| optimize_basis, name="optim", subp=subp, parser_kwargs=parser_kwargs | ||
| write_basis_to_yaml, name="build", subp=subp, parser_kwargs=parser_kwargs | ||
| ) | ||
| parser_kwargs["aliases"] = ("optim",) | ||
Check failureCode scanning / CodeQL Modification of parameter with default Error
This expression mutates a
default value Error loading related location Loading |
||
| get_argparse_parser( | ||
| write_basis_to_yaml, name="build", subp=subp, parser_kwargs=parser_kwargs | ||
| optimize_basis, name="optimize", subp=subp, parser_kwargs=parser_kwargs | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You need to update the documentation too then, at docs/toolbox/basis/basis.rst
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Or is
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. both are valid, but yes, I should have done that (will do!) |
||
| ) | ||
|
|
||
|
|
||
|
|
||
Check notice
Code scanning / CodeQL
Unused global variable Note