Correct the step for adding Snap dependency#20
Open
aaronshim wants to merge 1 commit intozfoh:masterfrom
Open
Conversation
Stack now generates the cabal file from the `package.yml` and `stack.yml` files. Also, the top-level package `snap` is not included in Stackage for the LTS version listed, so we must use the `solver` to pull in the extra dependencies.
Collaborator
|
Thanks for the PR! Introducing package.yaml makes the codelab go a bit out of sync -- makes it inconsistent. When using package.yaml one should not touch .cabal file. Do you mind updating the codelab so it always updates package.yaml instead of .cabal? And also update the memegen project? |
ivan444
reviewed
Feb 13, 2018
|
|
||
| Try to build the application by running `stack build`. It will fail. | ||
| The `snap` dependency is missing. Open the Cabal configuration and add the | ||
| The `snap` dependency is missing. Open the `package.yml` and add the |
Collaborator
There was a problem hiding this comment.
s/package.yml/package.yaml/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack now generates the cabal file from the
package.ymlandstack.ymlfiles. Also, the top-level packagesnapis not included in Stackage for the LTS version listed, so we must use thesolverto pull in the extra dependencies.