Try to detect language from html lang attributes and navigator.languages#38
Open
wangcheng wants to merge 9 commits intozhihu:masterfrom
Open
Try to detect language from html lang attributes and navigator.languages#38wangcheng wants to merge 9 commits intozhihu:masterfrom
wangcheng wants to merge 9 commits intozhihu:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 50.59% 50.59% -0.01%
==========================================
Files 124 127 +3
Lines 1753 1777 +24
==========================================
+ Hits 887 899 +12
- Misses 866 878 +12
Continue to review full report at Codecov.
|
lixiaoyan
suggested changes
Mar 27, 2019
| initialObjectFit = 'contain', | ||
| useMSE, | ||
| locale = 'en', | ||
| language, |
There was a problem hiding this comment.
看了下 Web 的 Intl API 也用的 locale 这个词。
Contributor
Author
There was a problem hiding this comment.
locale 和 language 还是不一样的。我们看起来只区分了语言,并没有区分「区域」,比如美国和英国词汇不同,数字格式不同之类的。
Collaborator
There was a problem hiding this comment.
我们这个属性可以填的值兼容了 locale 的写法,如果本意就是 locale 感觉写 locale 也没什么问题。美国英国的不同 locale 表现成同一种外观而已。
Collaborator
|
这个的进度怎么样呀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#37 # Description
htmllangattributes andnavigator.languagesChecklist: