skip certificate which is not part of the chain#25618
Open
ianic wants to merge 1 commit intoziglang:masterfrom
Open
skip certificate which is not part of the chain#25618ianic wants to merge 1 commit intoziglang:masterfrom
ianic wants to merge 1 commit intoziglang:masterfrom
Conversation
Fixes: 25606 Browsers and curl ignore extra irrelevant certificates in the chain. This fix skips certificate which is not part of the chain. Remaining certificates still form an unbroken chain of signatures with the last one trusted by root CA. Some other domain which also have extra certificates in the chain: - jhu.edu - last.fm - terra.com.br
|
It may be worth reading https://medium.com/@sleevi_/path-building-vs-path-verifying-the-chain-of-pain-9fbab861d7d6 and deciding whether to do path building rather than this. Note that full path building is required by TLS1.3 (ref https://datatracker.ietf.org/doc/html/rfc8446#section-4.4.2, the paragraph beginning "Note: Prior to TLS 1.3") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #25606
Browsers and curl ignore extra irrelevant certificates in the chain.
This fix skips certificate which is not part of the chain. Remaining certificates still form an unbroken chain of signatures with the last one trusted by root CA.
Some other domain which also have extra certificates in the chain: